| Message ID | 1383010340-26445-1-git-send-email-luka@openwrt.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
I've seen you use three inconsistent Subject prefixes here, pick a scheme
and stick to it please!
First patch was:
netdev: ${driver_name}:
Second patch was:
net: ${driver_name}:
Third patch was:
patch/to/driver/directory:
This is really not acceptable. Just using "${driver_name}: " is good
enough.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David, On Mon, Oct 28, 2013 at 11:48:42PM -0400, David Miller wrote: > I've seen you use three inconsistent Subject prefixes here, pick a scheme > and stick to it please! > > First patch was: > > netdev: ${driver_name}: > > Second patch was: > > net: ${driver_name}: > > Third patch was: > > patch/to/driver/directory: True. I have sent it that way because I've followed the commit schematics of each driver individually. > This is really not acceptable. Just using "${driver_name}: " is good > enough. It's not a problem to resend them... But I'm wondering should this be squashed into one patch? Luka -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index 9e16014..d818ded 100644 --- a/drivers/net/ethernet/arc/emac_main.c +++ b/drivers/net/ethernet/arc/emac_main.c @@ -725,10 +725,10 @@ static int arc_emac_probe(struct platform_device *pdev) /* Get MAC address from device tree */ mac_addr = of_get_mac_address(pdev->dev.of_node); - if (!mac_addr || !is_valid_ether_addr(mac_addr)) - eth_hw_addr_random(ndev); - else + if (mac_addr) memcpy(ndev->dev_addr, mac_addr, ETH_ALEN); + else + eth_hw_addr_random(ndev); dev_info(&pdev->dev, "MAC address is now %pM\n", ndev->dev_addr);
Checking if MAC address is valid using is_valid_ether_addr() is already done in of_get_mac_address(). While at it, reorganize checking so it matches checks in other drivers. Signed-off-by: Luka Perkov <luka@openwrt.org> --- drivers/net/ethernet/arc/emac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)