From patchwork Fri Jun 12 22:59:20 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 28652 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id F2AF9B715E for ; Sat, 13 Jun 2009 09:04:42 +1000 (EST) Received: by ozlabs.org (Postfix) id E02AADDD0C; Sat, 13 Jun 2009 09:04:42 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7CCC6DDD0B for ; Sat, 13 Jun 2009 09:04:42 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756581AbZFLXEa (ORCPT ); Fri, 12 Jun 2009 19:04:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753559AbZFLXEa (ORCPT ); Fri, 12 Jun 2009 19:04:30 -0400 Received: from rcsinet12.oracle.com ([148.87.113.124]:38807 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbZFLXE3 (ORCPT ); Fri, 12 Jun 2009 19:04:29 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5CN2eaC025897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Jun 2009 23:02:42 GMT Received: from abhmt003.oracle.com (abhmt003.oracle.com [141.146.116.12]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5CN45Ut014997; Fri, 12 Jun 2009 23:04:05 GMT Received: from [192.168.1.4] (/98.108.130.97) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 12 Jun 2009 16:02:52 -0700 Message-ID: <4A32DDC8.7060605@oracle.com> Date: Fri, 12 Jun 2009 15:59:20 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: David Miller CC: Stephen Rothwell , linux-next@vger.kernel.org, LKML , dbaryshkov@gmail.com, slapin@ossfans.org, linux-zigbee-devel@lists.sourceforge.net, Netdev , Andrew Morton Subject: [PATCH -next] ieee802154: fix kconfig bool/tristate muckup References: <20090611191420.1f4d5e4f.sfr@canb.auug.org.au> <4A31869B.3050901@oracle.com> In-Reply-To: <4A31869B.3050901@oracle.com> X-Source-IP: abhmt003.oracle.com [141.146.116.12] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010204.4A32DE9D.0133:SCFSTAT5015188,ss=1,fgs=0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Randy Dunlap menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154. If the IEEE802154 symbol is 'm', the bool becomes 'y'. This allows tristate symbols under IEEE802154_DRIVERS to be configured as 'y' and cause build problems. Changing the menuconfig bool to a tristate fixes this. drivers/built-in.o: In function `fake_scan_req': fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm' drivers/built-in.o: In function `fake_disassoc_req': fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm' drivers/built-in.o: In function `fake_assoc_req': fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm' Signed-off-by: Randy Dunlap Cc: linux-zigbee-devel@lists.sourceforge.net Cc: Dmitry Eremin-Solenikov Cc: Sergey Lapin --- drivers/ieee802154/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090612.orig/drivers/ieee802154/Kconfig +++ linux-next-20090612/drivers/ieee802154/Kconfig @@ -1,5 +1,5 @@ menuconfig IEEE802154_DRIVERS - bool "IEEE 802.15.4 drivers" + tristate "IEEE 802.15.4 drivers" depends on NETDEVICES && IEEE802154 default y ---help---