Patchwork [-next] ieee802154: fix kconfig bool/tristate muckup

login
register
mail settings
Submitter Randy Dunlap
Date June 12, 2009, 10:59 p.m.
Message ID <4A32DDC8.7060605@oracle.com>
Download mbox | patch
Permalink /patch/28652/
State Accepted
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - June 12, 2009, 10:59 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
If the IEEE802154 symbol is 'm', the bool becomes 'y'.
This allows tristate symbols under IEEE802154_DRIVERS to be configured as
'y' and cause build problems.
Changing the menuconfig bool to a tristate fixes this.

drivers/built-in.o: In function `fake_scan_req':
fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm'
drivers/built-in.o: In function `fake_disassoc_req':
fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm'
drivers/built-in.o: In function `fake_assoc_req':
fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-zigbee-devel@lists.sourceforge.net
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Sergey Lapin <slapin@ossfans.org>
---
 drivers/ieee802154/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sergey Lapin - June 13, 2009, 10:57 a.m.
On Fri, Jun 12, 2009 at 03:59:20PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
> If the IEEE802154 symbol is 'm', the bool becomes 'y'.
> This allows tristate symbols under IEEE802154_DRIVERS to be configured as
> 'y' and cause build problems.
> Changing the menuconfig bool to a tristate fixes this.
> 
> drivers/built-in.o: In function `fake_scan_req':
> fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm'
> drivers/built-in.o: In function `fake_disassoc_req':
> fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm'
> drivers/built-in.o: In function `fake_assoc_req':
> fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: linux-zigbee-devel@lists.sourceforge.net
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Sergey Lapin <slapin@ossfans.org>
Ackedy-by: Sergey Lapin <slapin@ossfans.org>

Thanks a lot!
S.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - June 14, 2009, 6:37 a.m.
From: Sergey Lapin <slapin@ossfans.org>
Date: Sat, 13 Jun 2009 14:57:54 +0400

> On Fri, Jun 12, 2009 at 03:59:20PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>> 
>> menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
>> If the IEEE802154 symbol is 'm', the bool becomes 'y'.
>> This allows tristate symbols under IEEE802154_DRIVERS to be configured as
>> 'y' and cause build problems.
>> Changing the menuconfig bool to a tristate fixes this.
>> 
>> drivers/built-in.o: In function `fake_scan_req':
>> fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm'
>> drivers/built-in.o: In function `fake_disassoc_req':
>> fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm'
>> drivers/built-in.o: In function `fake_assoc_req':
>> fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm'
>> 
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: linux-zigbee-devel@lists.sourceforge.net
>> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> Cc: Sergey Lapin <slapin@ossfans.org>
> Ackedy-by: Sergey Lapin <slapin@ossfans.org>

It's "Acked-by:" :-)

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20090612.orig/drivers/ieee802154/Kconfig
+++ linux-next-20090612/drivers/ieee802154/Kconfig
@@ -1,5 +1,5 @@ 
 menuconfig IEEE802154_DRIVERS
-	bool "IEEE 802.15.4 drivers"
+	tristate "IEEE 802.15.4 drivers"
 	depends on NETDEVICES && IEEE802154
 	default y
 	---help---