diff mbox

[v3,2/2] ModemManager: add new package

Message ID 1382962191-6274-2-git-send-email-yegorslists@googlemail.com
State Superseded
Headers show

Commit Message

Yegor Yefremov Oct. 28, 2013, 12:09 p.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes:
	v3: depend on pcre, fix comments and indentation etc. (comments from Thomas Petazzoni)
	v2: typos, add select QMI to the config option, don't install to staging
 package/Config.in                      |    1 +
 package/modem-manager/Config.in        |   33 ++++++++++++++++++++++++++++++++
 package/modem-manager/modem-manager.mk |   23 ++++++++++++++++++++++
 3 files changed, 57 insertions(+), 0 deletions(-)
 create mode 100644 package/modem-manager/Config.in
 create mode 100644 package/modem-manager/modem-manager.mk

Comments

Arnout Vandecappelle Oct. 29, 2013, 5:09 p.m. UTC | #1 
On 28/10/13 13:09, yegorslists@googlemail.com wrote:
[snip]
> +comment "modemmanager requires a toolchain with IPV6, LARGEFILE, WCHAR and thread support and the udev infrastructure"
> +	depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
> +		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV

 We've standardized this type of comment into

comment "modemmanager needs udev and a toolchain w/ largefile, wchar, threads, IPv6"


 Regards,
 Arnout

[snip]
Yegor Yefremov Oct. 30, 2013, 7:48 a.m. UTC | #2 
On Tue, Oct 29, 2013 at 6:09 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 28/10/13 13:09, yegorslists@googlemail.com wrote:
> [snip]
>> +comment "modemmanager requires a toolchain with IPV6, LARGEFILE, WCHAR and thread support and the udev infrastructure"
>> +     depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
>> +             !BR2_TOOLCHAIN_HAS_THREADS || !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
>
>  We've standardized this type of comment into
>
> comment "modemmanager needs udev and a toolchain w/ largefile, wchar, threads, IPv6"

Thanks. Will send v4

Yegor
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 0e6f86c..34c0e7b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -820,6 +820,7 @@  source "package/lrzsz/Config.in"
 source "package/macchanger/Config.in"
 source "package/mii-diag/Config.in"
 source "package/minidlna/Config.in"
+source "package/modem-manager/Config.in"
 source "package/mongoose/Config.in"
 source "package/mongrel2/Config.in"
 source "package/mrouted/Config.in"
diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
new file mode 100644
index 0000000..0ee9ba1
--- /dev/null
+++ b/package/modem-manager/Config.in
@@ -0,0 +1,33 @@ 
+config BR2_PACKAGE_MODEM_MANAGER
+	bool "modemmanager"
+	depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+	select BR2_PACKAGE_DBUS
+	depends on BR2_INET_IPV6
+	depends on BR2_LARGEFILE # acl
+	depends on BR2_USE_WCHAR # libglib2 and gnutls
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus
+	select BR2_PACKAGE_DBUS_GLIB
+	select BR2_PACKAGE_UDEV
+	select BR2_PACKAGE_UDEV_ALL_EXTRAS
+	select BR2_PACKAGE_PCRE
+	select BR2_PACKAGE_PCRE_UTF
+	help
+	  ModemManager is a DBus-activated daemon which controls mobile
+	  broadband (2G/3G/4G) devices and connections.
+
+	  http://www.freedesktop.org/wiki/Software/ModemManager/
+
+if BR2_PACKAGE_MODEM_MANAGER
+
+config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
+	bool "QMI support"
+	select BR2_PACKAGE_LIBQMI
+	help
+	  This option enables support for QMI protocol
+endif
+
+comment "modemmanager requires a toolchain with IPV6, LARGEFILE, WCHAR and thread support and the udev infrastructure"
+	depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
new file mode 100644
index 0000000..f43a598
--- /dev/null
+++ b/package/modem-manager/modem-manager.mk
@@ -0,0 +1,23 @@ 
+################################################################################
+#
+# modem-manager
+#
+################################################################################
+
+MODEM_MANAGER_VERSION = 1.0.0
+MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
+MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager/
+MODEM_MANAGER_LICENSE = GPLv2
+MODEM_MANAGER_LICENSE_FILES = COPYING
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev dbus-glib host-intltool pcre
+
+MODEM_MANAGER_CONF_OPT = --without-mbim
+
+ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
+	MODEM_MANAGER_DEPENDENCIES += libqmi
+	MODEM_MANAGER_CONF_OPT += --with-qmi
+else
+	MODEM_MANAGER_CONF_OPT += --without-qmi
+endif
+
+$(eval $(autotools-package))