Patchwork xdriver_xf86-video-geode: only build on i386

login
register
mail settings
Submitter Arnout Vandecappelle
Date Oct. 24, 2013, 10:50 p.m.
Message ID <1382655055-3520-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/286048/
State Accepted
Commit fba37e839106999a4052cfdb269f9d448fe962fd
Headers show

Comments

Arnout Vandecappelle - Oct. 24, 2013, 10:50 p.m.
This package builds with -m32. In buildroot, we don't have multilib
support so only the 64-bit libraries are available, which can't be
linked against these 32-bit object files.

I've tested this with the Sourcery and buildroot toolchains - neither
works.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/x11r7/xdriver_xf86-video-geode/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Gustavo Zacarias - Oct. 24, 2013, 10:59 p.m.
On 10/24/2013 07:50 PM, Arnout Vandecappelle (Essensium/Mind) wrote:

> This package builds with -m32. In buildroot, we don't have multilib
> support so only the 64-bit libraries are available, which can't be
> linked against these 32-bit object files.
> 
> I've tested this with the Sourcery and buildroot toolchains - neither
> works.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

(The geode is NSC's old embedded x86 chip with on-chip video so no
64-bit variant and no standalone cards).
Peter Korsgaard - Oct. 25, 2013, 7:28 a.m.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > This package builds with -m32. In buildroot, we don't have multilib
 > support so only the 64-bit libraries are available, which can't be
 > linked against these 32-bit object files.

 > I've tested this with the Sourcery and buildroot toolchains - neither
 > works.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.

Patch

diff --git a/package/x11r7/xdriver_xf86-video-geode/Config.in b/package/x11r7/xdriver_xf86-video-geode/Config.in
index 2b868d0..0b45fb1 100644
--- a/package/x11r7/xdriver_xf86-video-geode/Config.in
+++ b/package/x11r7/xdriver_xf86-video-geode/Config.in
@@ -5,6 +5,6 @@  config BR2_PACKAGE_XDRIVER_XF86_VIDEO_GEODE
 	select BR2_PACKAGE_XPROTO_RENDERPROTO
 	select BR2_PACKAGE_XPROTO_VIDEOPROTO
 	select BR2_PACKAGE_XPROTO_XPROTO
-	depends on (BR2_i386 || BR2_x86_64)
+	depends on BR2_i386
 	help
 	  video driver for geode device