diff mbox

[net-next] natsemi: fix legacy printk() style

Message ID 1382650646-24009-1-git-send-email-quantumdude836@gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Drew McGowen Oct. 24, 2013, 9:37 p.m. UTC 
Fixed printk() calls to use KERN_* prefix (some were not changed because they
are continuations of a previous line).

Reviewed-by: Sarabeth Jaffe <jaffes2@rpi.edu>
Reviewed-by: Marcio Barbosa <marcio.brito.barbosa@gmail.com>
Reviewed-by: Sean Heyse <heyses@rpi.edu>
Signed-off-by: Drew McGowen <quantumdude836@gmail.com>
---
 drivers/net/ethernet/natsemi/natsemi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Joe Perches Oct. 24, 2013, 10:33 p.m. UTC | #1 
On Thu, 2013-10-24 at 21:37 +0000, Drew McGowen wrote:
> Fixed printk() calls to use KERN_* prefix (some were not changed because they
> are continuations of a previous line).
[]
> diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c
[]
> @@ -814,7 +814,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
>  #ifndef MODULE
>  	static int printed_version;
>  	if (!printed_version++)
> -		printk(version);
> +		printk(KERN_INFO version);

pr_info_once("%s\n", version);

And remove the trailing newline from version

> @@ -3360,7 +3360,7 @@ static int __init natsemi_init_mod (void)
>  {
>  /* when a module, this is printed whether or not devices are found in probe */
>  #ifdef MODULE
> -	printk(version);
> +	printk(KERN_INFO version);

	pr_info("%s\n", version);

Nicer to use netdev_<level> too.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c
index 7a5e295..cd39d8e 100644
--- a/drivers/net/ethernet/natsemi/natsemi.c
+++ b/drivers/net/ethernet/natsemi/natsemi.c
@@ -814,7 +814,7 @@  static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
 #ifndef MODULE
 	static int printed_version;
 	if (!printed_version++)
-		printk(version);
+		printk(KERN_INFO version);
 #endif
 
 	i = pci_enable_device(pdev);
@@ -3360,7 +3360,7 @@  static int __init natsemi_init_mod (void)
 {
 /* when a module, this is printed whether or not devices are found in probe */
 #ifdef MODULE
-	printk(version);
+	printk(KERN_INFO version);
 #endif
 
 	return pci_register_driver(&natsemi_driver);