diff mbox

[U-Boot] cmd_sf: Mention in the help text that mode, addr, offset and len must be given in hex.

Message ID 1382622245-41483-1-git-send-email-jakob.unterwurzacher@theobroma-systems.com
State Rejected
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Jakob Unterwurzacher Oct. 24, 2013, 1:44 p.m. UTC
These parameters are always interpreted as hex, even without 0x prefix.

Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
---
 common/cmd_sf.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Jagan Teki Jan. 8, 2014, 12:47 p.m. UTC | #1
On Thu, Oct 24, 2013 at 7:14 PM, Jakob Unterwurzacher
<jakob.unterwurzacher@theobroma-systems.com> wrote:
> These parameters are always interpreted as hex, even without 0x prefix.
>
> Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
> ---
>  common/cmd_sf.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/common/cmd_sf.c b/common/cmd_sf.c
> index 0a17782..0f7c0a3 100644
> --- a/common/cmd_sf.c
> +++ b/common/cmd_sf.c
> @@ -531,6 +531,7 @@ U_BOOT_CMD(
>         "sf erase offset [+]len         - erase `len' bytes from `offset'\n"
>         "                                 `+len' round up `len' to block size\n"
>         "sf update addr offset len      - erase and write `len' bytes from memory\n"
> -       "                                 at `addr' to flash at `offset'"
> +       "                                 at `addr' to flash at `offset'\n"
> +       "Parameters mode, addr, offset and len must be in hex."
>         SF_TEST_HELP
>  );
All in u-boot treated similar, i don't think the point here to add notes.
Sorry, rejected.
diff mbox

Patch

diff --git a/common/cmd_sf.c b/common/cmd_sf.c
index 0a17782..0f7c0a3 100644
--- a/common/cmd_sf.c
+++ b/common/cmd_sf.c
@@ -531,6 +531,7 @@  U_BOOT_CMD(
 	"sf erase offset [+]len		- erase `len' bytes from `offset'\n"
 	"				  `+len' round up `len' to block size\n"
 	"sf update addr offset len	- erase and write `len' bytes from memory\n"
-	"				  at `addr' to flash at `offset'"
+	"				  at `addr' to flash at `offset'\n"
+	"Parameters mode, addr, offset and len must be in hex."
 	SF_TEST_HELP
 );