Patchwork Fix up pr58508.c testcase

login
register
mail settings
Submitter Jakub Jelinek
Date Oct. 22, 2013, 7:26 p.m.
Message ID <20131022192619.GP30970@tucnak.zalov.cz>
Download mbox | patch
Permalink /patch/285488/
State New
Headers show

Comments

Jakub Jelinek - Oct. 22, 2013, 7:26 p.m.
Hi!

I've noticed that this testcase fails on i686-linux.  The problem is
that the vect.exp infrastructure is terrible and dg-options overrides
all the required flags.  So, vect/ testcases either don't have to have
explicit options at all (and the way to express options is through magic
naming of the tests), or one can use dg-additional-options.  But, in this
case you just want to pass the defaults.

Regtested on x86_64-linux and i686-linux, ok for trunk?

2013-10-22  Jakub Jelinek  <jakub@redhat.com>

	* gcc.dg/vect/pr58508.c: Remove dg-options.


	Jakub
Richard Guenther - Oct. 23, 2013, 9:55 a.m.
On Tue, Oct 22, 2013 at 9:26 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> I've noticed that this testcase fails on i686-linux.  The problem is
> that the vect.exp infrastructure is terrible and dg-options overrides
> all the required flags.  So, vect/ testcases either don't have to have
> explicit options at all (and the way to express options is through magic
> naming of the tests), or one can use dg-additional-options.  But, in this
> case you just want to pass the defaults.
>
> Regtested on x86_64-linux and i686-linux, ok for trunk?

Ok.  Btw, it handles dg-additional-options just fine I think.

Richard.

> 2013-10-22  Jakub Jelinek  <jakub@redhat.com>
>
>         * gcc.dg/vect/pr58508.c: Remove dg-options.
>
> --- gcc/testsuite/gcc.dg/vect/pr58508.c.jj      2013-10-21 09:00:49.000000000 +0200
> +++ gcc/testsuite/gcc.dg/vect/pr58508.c 2013-10-22 14:21:16.064261179 +0200
> @@ -1,5 +1,4 @@
>  /* { dg-do compile } */
> -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
>
>
>  /* The GCC vectorizer generates loop versioning for the following loop
>
>         Jakub

Patch

--- gcc/testsuite/gcc.dg/vect/pr58508.c.jj	2013-10-21 09:00:49.000000000 +0200
+++ gcc/testsuite/gcc.dg/vect/pr58508.c	2013-10-22 14:21:16.064261179 +0200
@@ -1,5 +1,4 @@ 
 /* { dg-do compile } */
-/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
 
 
 /* The GCC vectorizer generates loop versioning for the following loop