diff mbox

[C++,obvious?] PR 58816

Message ID 52663911.6080705@oracle.com
State New
Headers show

Commit Message

Paolo Carlini Oct. 22, 2013, 8:36 a.m. UTC 
Hi,

this issue, where we should be using get_attribute_name, which works 
both with GNU and C++11 attributes, instead of TREE_PURPOSE, shows up as 
many unexpected fails of the cpp0x/gen-attrs* tests on AIX. David tested 
the patchlet on AIX and I double checked it on x86_64-linux. I think the 
change qualifies as obvious and I will commit it later today if nobody 
objects.

Thanks!
Paolo.

////////////////////////
2013-10-22  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/58816
	* pt.c (apply_late_template_attributes): Use get_attribute_name,
	not TREE_PURPOSE.

Comments

Jason Merrill Oct. 22, 2013, 11:02 a.m. UTC | #1 
OK, thanks.

Jason
Paolo Carlini Oct. 22, 2013, 2:27 p.m. UTC | #2 
On 10/22/2013 01:02 PM, Jason Merrill wrote:
> OK, thanks.
Applied.

Shall I apply this one too:

     http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01166.html

?

Thanks,
Paolo.
diff mbox

Patch

Index: pt.c
===================================================================
--- pt.c	(revision 203915)
+++ pt.c	(working copy)
@@ -8610,7 +8610,7 @@  apply_late_template_attributes (tree *decl_p, tree
 		 pass it through tsubst.  Attributes like mode, format,
 		 cleanup and several target specific attributes expect it
 		 unmodified.  */
-	      else if (attribute_takes_identifier_p (TREE_PURPOSE (t)))
+	      else if (attribute_takes_identifier_p (get_attribute_name (t)))
 		{
 		  tree chain
 		    = tsubst_expr (TREE_CHAIN (TREE_VALUE (t)), args, complain,