Patchwork e2fsck: fix problem comments to match actual message

login
register
mail settings
Submitter Andreas Dilger
Date Oct. 22, 2013, 3:54 a.m.
Message ID <1382414047-93725-1-git-send-email-andreas.dilger@intel.com>
Download mbox | patch
Permalink /patch/285343/
State Accepted
Headers show

Comments

Andreas Dilger - Oct. 22, 2013, 3:54 a.m.
Fix the e2fsck problem comments to match the actual message printed,
so that it is possible to find the problem code when searching by
the message.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
---
 e2fsck/problem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Andreas Dilger - Oct. 22, 2013, 4:12 a.m.
On 2013/10/21 9:54 PM, "Dilger, Andreas" <andreas.dilger@intel.com> wrote:

>Fix the e2fsck problem comments to match the actual message printed,
>so that it is possible to find the problem code when searching by
>the message.

Ted,
have you thought about getting rid of the error message compression in
e2fsck?  I think the compression isn't useful anymore, and the escape
codes makes it much harder to debug and understand the code.

Cheers, Andreas

>Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
>---
> e2fsck/problem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/e2fsck/problem.c b/e2fsck/problem.c
>index b0a6e19..2a6c937 100644
>--- a/e2fsck/problem.c
>+++ b/e2fsck/problem.c
>@@ -1118,12 +1118,12 @@ static struct e2fsck_problem problem_table[] = {
> 	  N_("@n @i number for '.' in @d @i %i.\n"),
> 	  PROMPT_FIX, 0 },
> 
>-	/* Directory entry has bad inode number */
>+	/* Entry 'xxxx' in /a/b/c has bad inode number.*/
> 	{ PR_2_BAD_INO,
> 	  N_("@E has @n @i #: %Di.\n"),
> 	  PROMPT_CLEAR, 0 },
> 
>-	/* Directory entry has deleted or unused inode */
>+	/* Entry 'xxxx' in /a/b/c has deleted/unused inode nnnnn.*/
> 	{ PR_2_UNUSED_INODE,
> 	  N_("@E has @D/unused @i %Di.  "),
> 	  PROMPT_CLEAR, PR_PREEN_OK },
>-- 
>1.7.11.5
>
>


Cheers, Andreas
Theodore Ts'o - Dec. 12, 2013, 1:11 a.m.
On Mon, Oct 21, 2013 at 09:54:07PM -0600, Andreas Dilger wrote:
> Fix the e2fsck problem comments to match the actual message printed,
> so that it is possible to find the problem code when searching by
> the message.
> 
> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index b0a6e19..2a6c937 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -1118,12 +1118,12 @@  static struct e2fsck_problem problem_table[] = {
 	  N_("@n @i number for '.' in @d @i %i.\n"),
 	  PROMPT_FIX, 0 },
 
-	/* Directory entry has bad inode number */
+	/* Entry 'xxxx' in /a/b/c has bad inode number.*/
 	{ PR_2_BAD_INO,
 	  N_("@E has @n @i #: %Di.\n"),
 	  PROMPT_CLEAR, 0 },
 
-	/* Directory entry has deleted or unused inode */
+	/* Entry 'xxxx' in /a/b/c has deleted/unused inode nnnnn.*/
 	{ PR_2_UNUSED_INODE,
 	  N_("@E has @D/unused @i %Di.  "),
 	  PROMPT_CLEAR, PR_PREEN_OK },