Patchwork [1/8] Revert commit d763c959

login
register
mail settings
Submitter Chuck Lever
Date Oct. 21, 2013, 9:50 p.m.
Message ID <20131021215044.38809.84682.stgit@manray.1015granger.net>
Download mbox | patch
Permalink /patch/285282/
State Accepted
Headers show

Comments

Chuck Lever - Oct. 21, 2013, 9:50 p.m.
Since commit d763c959, "build: do not link plug-ins against .so
libs", Jun 25 13:44:04 2013, junction resolution fails.  Mountd
reports:

  rpc.mountd[30762]: lookup_junction: dlopen: /lib64/libnfsjunct.so:
    undefined symbol: xmlFree

The patch description for this commit reads "Binaries using the
plug-ins static library will need to link against required shared
libraries themselves."  However, this plug-in is always loaded via
dlopen(3), and is not intended to be statically linked with other
utilities.

I suspect a change like d763c959 would need to be accompanied by a
code or build change in mountd to deal with missing symbols when the
plug-in is loaded.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: David Disseldorp <ddiss@suse.de>
---
 src/plug-ins/Makefile.am |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Patch

diff --git a/src/plug-ins/Makefile.am b/src/plug-ins/Makefile.am
index cf40c8a..b804fce 100644
--- a/src/plug-ins/Makefile.am
+++ b/src/plug-ins/Makefile.am
@@ -25,7 +25,10 @@ 
 
 lib_LTLIBRARIES		= libnfsjunct.la
 libnfsjunct_la_SOURCES	= nfs-plugin.c
-libnfsjunct_la_LIBADD	= $(top_builddir)/src/libnsdb/libnsdb.la \
+libnfsjunct_la_LIBADD	= $(LIBLDAP) $(LIBLBER) $(LIBXML2) \
+			  $(LIBSQLITE3) $(LIBIDN) $(LIBUUID) \
+			  $(LIBURIPARSER) $(LIBCRYPTO) $(LIBSSL) \
+			  $(top_builddir)/src/libnsdb/libnsdb.la \
 			  $(top_builddir)/src/libxlog/libxlog.la \
 			  $(top_builddir)/src/libjunction/libjunction.la