| Message ID | 1382318045-23836-2-git-send-email-yamada.m@jp.panasonic.com |
|---|---|
| State | Rejected |
| Delegated to: | Sonic Zhang |
| Headers | show |
Hi Masahiro, NAK. The variable uart_base is used in macro pUART in function serial_init(). #define pUART ((volatile struct bfin_mmr_serial *)uart_base) Regards, Sonic On Mon, Oct 21, 2013 at 9:14 AM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote: > This commit fixes: > initcode.c:150: warning: unused variable ‘uart_base’ > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > Cc: Sonic Zhang <sonic.zhang@analog.com> > --- > arch/blackfin/cpu/initcode.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/blackfin/cpu/initcode.c b/arch/blackfin/cpu/initcode.c > index ffaf101..956f158 100644 > --- a/arch/blackfin/cpu/initcode.c > +++ b/arch/blackfin/cpu/initcode.c > @@ -147,8 +147,6 @@ static struct ddr_config ddr_config_table[] = { > __attribute__((always_inline)) > static inline void serial_init(void) > { > - uint32_t uart_base = UART_BASE; > - > #if defined(__ADSPBF54x__) || defined(__ADSPBF60x__) > # ifdef BFIN_BOOT_UART_USE_RTS > # define BFIN_UART_USE_RTS 1 > @@ -195,8 +193,8 @@ static inline void serial_init(void) > > #if CONFIG_BFIN_BOOT_MODE != BFIN_BOOT_BYPASS > if (BFIN_DEBUG_EARLY_SERIAL) { > - serial_early_init(uart_base); > - serial_early_set_baud(uart_base, CONFIG_BAUDRATE); > + serial_early_init(UART_BASE); > + serial_early_set_baud(UART_BASE, CONFIG_BAUDRATE); > } > #endif > } > -- > 1.8.1.2 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Hello, Sonic. > The variable uart_base is used in macro pUART in function serial_init(). > > > #define pUART ((volatile struct bfin_mmr_serial *)uart_base) This macro is weird. It expects the variable name 'uart_base'. I think it's better not to use it. Best Regards Masahiro Yamada
diff --git a/arch/blackfin/cpu/initcode.c b/arch/blackfin/cpu/initcode.c index ffaf101..956f158 100644 --- a/arch/blackfin/cpu/initcode.c +++ b/arch/blackfin/cpu/initcode.c @@ -147,8 +147,6 @@ static struct ddr_config ddr_config_table[] = { __attribute__((always_inline)) static inline void serial_init(void) { - uint32_t uart_base = UART_BASE; - #if defined(__ADSPBF54x__) || defined(__ADSPBF60x__) # ifdef BFIN_BOOT_UART_USE_RTS # define BFIN_UART_USE_RTS 1 @@ -195,8 +193,8 @@ static inline void serial_init(void) #if CONFIG_BFIN_BOOT_MODE != BFIN_BOOT_BYPASS if (BFIN_DEBUG_EARLY_SERIAL) { - serial_early_init(uart_base); - serial_early_set_baud(uart_base, CONFIG_BAUDRATE); + serial_early_init(UART_BASE); + serial_early_set_baud(UART_BASE, CONFIG_BAUDRATE); } #endif }
This commit fixes: initcode.c:150: warning: unused variable ‘uart_base’ Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Cc: Sonic Zhang <sonic.zhang@analog.com> --- arch/blackfin/cpu/initcode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)