| Message ID | 1382137374-21251-9-git-send-email-ezequiel.garcia@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Oct 18, 2013 at 08:02:35PM -0300, Ezequiel Garcia wrote: > @@ -1011,14 +1011,16 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info) > static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info) > { > struct mtd_info *mtd; > + struct nand_chip *chip; > int ret; Please add a empty line here. > mtd = info->host[info->cs]->mtd; > + chip = mtd->priv; > /* use the common timing to make a try */ > ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]); > if (ret) > return ret; > > - pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0); > + chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0); > if (info->is_ready) > return 0; Reviewed-by: Huang Shijie <shijie8@gmail.com>
On Sun, Nov 03, 2013 at 04:32:40PM -0500, Huang Shijie wrote: > On Fri, Oct 18, 2013 at 08:02:35PM -0300, Ezequiel Garcia wrote: > > @@ -1011,14 +1011,16 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info) > > static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info) > > { > > struct mtd_info *mtd; > > + struct nand_chip *chip; > > int ret; > Please add a empty line here. > Sure, I will. > > mtd = info->host[info->cs]->mtd; > > + chip = mtd->priv; > > /* use the common timing to make a try */ > > ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]); > > if (ret) > > return ret; > > > > - pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0); > > + chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0); > > if (info->is_ready) > > return 0; > Reviewed-by: Huang Shijie <shijie8@gmail.com> Thanks!
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index 83ea806..1e2f4ae 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -1011,14 +1011,16 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info) static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info) { struct mtd_info *mtd; + struct nand_chip *chip; int ret; mtd = info->host[info->cs]->mtd; + chip = mtd->priv; /* use the common timing to make a try */ ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]); if (ret) return ret; - pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0); + chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0); if (info->is_ready) return 0;
Whenever possible, it's always better to use the generic chip->cmdfunc instead of the internal pxa3xx_nand_cmdfunc(). In this particular case, this will allow to have multiple cmdfunc() implementations for different SoC variants. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- drivers/mtd/nand/pxa3xx_nand.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)