diff mbox

[2/8] Remove tree-ssa-address.h from the tree-ssa.h include list.

Message ID 526139BF.4050607@redhat.com
State New
Headers show

Commit Message

Andrew MacLeod Oct. 18, 2013, 1:38 p.m. UTC 
This patch just does the direct thing.. included the file where it was 
needed (7 .c files)   I was tempted to move copy_ref_info() to a 
different file... its actually the only routine in this file which is 
SSA based... and rename the file tree-address.[ch].  Not sure where I'd 
copy it to, maybe tree-ssa.c... Almost every routine called is in 
tree-ssanames.c, but that doesnt seem quite appropriate. Maybe its OK 
like it is.

In any case, if you want something further done, I can follow up with 
another patch.

bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK?

Andrew

Comments

Jeff Law Oct. 18, 2013, 4:02 p.m. UTC | #1 
On 10/18/13 07:38, Andrew MacLeod wrote:
> This patch just does the direct thing.. included the file where it was
> needed (7 .c files)   I was tempted to move copy_ref_info() to a
> different file... its actually the only routine in this file which is
> SSA based... and rename the file tree-address.[ch].  Not sure where I'd
> copy it to, maybe tree-ssa.c... Almost every routine called is in
> tree-ssanames.c, but that doesnt seem quite appropriate. Maybe its OK
> like it is.
>
> In any case, if you want something further done, I can follow up with
> another patch.
>
> bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK?
OK.

Your call on moving copy_ref_into now or at a later point, similarly on 
renaming file afterwards.

jeff
diff mbox

Patch


	* tree-ssa.h: Don't include tree-ssa-address.h.
	* cfgexpand.c: Add tree-ssa-address.h to include list.
	* expr.c: Likewise.
	* gimple-fold.c: Likewise.
	* gimple-ssa-strength-reduction.c: Likewise.
	* trans-mem.c: Likewise.
	* tree-mudflap.c: Likewise.
	* tree-ssa-loop-ivopts.c: Likewise.

*** T3/tree-ssa.h	2013-10-17 10:52:02.858047334 -0400
--- tree-ssa.h	2013-10-17 12:10:07.460476961 -0400
*************** along with GCC; see the file COPYING3.
*** 33,39 ****
  #include "tree-ssanames.h"
  #include "tree-ssa-dom.h"
  #include "tree-ssa-threadedge.h"
- #include "tree-ssa-address.h"
  #include "tree-ssa-loop.h"
  #include "tree-into-ssa.h"
  #include "tree-dfa.h"
--- 33,38 ----
*** T3/cfgexpand.c	2013-10-17 10:52:02.825047320 -0400
--- cfgexpand.c	2013-10-17 12:21:13.884452160 -0400
*************** along with GCC; see the file COPYING3.
*** 47,52 ****
--- 47,53 ----
  #include "regs.h" /* For reg_renumber.  */
  #include "insn-attr.h" /* For INSN_SCHEDULING.  */
  #include "asan.h"
+ #include "tree-ssa-address.h"
  
  /* This variable holds information helping the rewriting of SSA trees
     into RTL.  */
*** T3/expr.c	2013-10-17 10:52:02.831047323 -0400
--- expr.c	2013-10-17 12:22:05.594452615 -0400
*************** along with GCC; see the file COPYING3.
*** 52,57 ****
--- 52,58 ----
  #include "tree-outof-ssa.h"
  #include "target-globals.h"
  #include "params.h"
+ #include "tree-ssa-address.h"
  
  /* Decide whether a function's arguments should be processed
     from first to last or from last to first.
*** T3/gimple-fold.c	2013-10-17 10:52:02.836047325 -0400
--- gimple-fold.c	2013-10-17 12:21:57.753452521 -0400
*************** along with GCC; see the file COPYING3.
*** 31,36 ****
--- 31,37 ----
  #include "target.h"
  #include "ipa-utils.h"
  #include "gimple-pretty-print.h"
+ #include "tree-ssa-address.h"
  
  /* Return true when DECL can be referenced from current unit.
     FROM_DECL (if non-null) specify constructor of variable DECL was taken from.
*** T3/gimple-ssa-strength-reduction.c	2013-10-17 10:52:02.836047325 -0400
--- gimple-ssa-strength-reduction.c	2013-10-17 12:21:05.563452124 -0400
*************** along with GCC; see the file COPYING3.
*** 48,53 ****
--- 48,54 ----
  #include "expmed.h"
  #include "params.h"
  #include "hash-table.h"
+ #include "tree-ssa-address.h"
  
  /* Information about a strength reduction candidate.  Each statement
     in the candidate table represents an expression of one of the
*** T3/trans-mem.c	2013-10-17 10:52:02.853047332 -0400
--- trans-mem.c	2013-10-17 12:21:09.283452139 -0400
***************
*** 35,40 ****
--- 35,41 ----
  #include "langhooks.h"
  #include "gimple-pretty-print.h"
  #include "cfgloop.h"
+ #include "tree-ssa-address.h"
  
  
  #define PROB_VERY_UNLIKELY	(REG_BR_PROB_BASE / 2000 - 1)
*** T3/tree-mudflap.c	2013-10-17 10:52:02.856047334 -0400
--- tree-mudflap.c	2013-10-17 12:20:54.929452093 -0400
*************** along with GCC; see the file COPYING3.
*** 42,47 ****
--- 42,48 ----
  #include "ggc.h"
  #include "cgraph.h"
  #include "gimple.h"
+ #include "tree-ssa-address.h"
  
  extern void add_bb_to_loop (basic_block, struct loop *);
  
*** T3/tree-ssa-loop-ivopts.c	2013-10-17 10:52:02.859047335 -0400
--- tree-ssa-loop-ivopts.c	2013-10-17 12:20:59.933452106 -0400
*************** along with GCC; see the file COPYING3.
*** 86,91 ****
--- 86,92 ----
  #include "tree-inline.h"
  #include "tree-ssa-propagate.h"
  #include "expmed.h"
+ #include "tree-ssa-address.h"
  
  /* FIXME: Expressions are expanded to RTL in this pass to determine the
     cost of different addressing modes.  This should be moved to a TBD