Patchwork [v8,RESEND,6/8] uclibc: add support for top-level parallel make

login
register
mail settings
Submitter Fabio Porcedda
Date Oct. 18, 2013, 9:34 a.m.
Message ID <1382088860-30524-7-git-send-email-fabio.porcedda@gmail.com>
Download mbox | patch
Permalink /patch/284488/
State Superseded
Headers show

Comments

Fabio Porcedda - Oct. 18, 2013, 9:34 a.m.
To be able to use top-level parallel make we must not depend in a rule
on the order of evaluation of the prerequisites, so instead of relyng on
the left to right ordering of evaluation of the prerequisites add an
explicit rule to describe the dependencies.

The uclibc-install-target depends on uclibc-install-staging so add a
rule for it.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/uclibc/uclibc.mk | 2 ++
 1 file changed, 2 insertions(+)
Arnout Vandecappelle - Oct. 23, 2013, 10:49 p.m.
On 18/10/13 11:34, Fabio Porcedda wrote:
> To be able to use top-level parallel make we must not depend in a rule
> on the order of evaluation of the prerequisites, so instead of relyng on
> the left to right ordering of evaluation of the prerequisites add an
> explicit rule to describe the dependencies.
>
> The uclibc-install-target depends on uclibc-install-staging so add a
> rule for it.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>   package/uclibc/uclibc.mk | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index dea36e7..c8eeb3d 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -559,3 +559,5 @@ uclibc-menuconfig: dirs uclibc-patch
>   	rm -f $(UCLIBC_DIR)/.stamp_{configured,built,target_installed,staging_installed}
>
>   $(eval $(generic-package))
> +
> +$(UCLIBC_TARGET_INSTALL_TARGET): $(UCLIBC_TARGET_INSTALL_STAGING)
>

  Same nitpick :-)

  Regards,
  Arnout
Fabio Porcedda - Nov. 11, 2013, 12:50 p.m.
On Thu, Oct 24, 2013 at 12:49 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 18/10/13 11:34, Fabio Porcedda wrote:
>>
>> To be able to use top-level parallel make we must not depend in a rule
>> on the order of evaluation of the prerequisites, so instead of relyng on
>> the left to right ordering of evaluation of the prerequisites add an
>> explicit rule to describe the dependencies.
>>
>> The uclibc-install-target depends on uclibc-install-staging so add a
>> rule for it.
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Added, thanks.

>
>> ---
>>   package/uclibc/uclibc.mk | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
>> index dea36e7..c8eeb3d 100644
>> --- a/package/uclibc/uclibc.mk
>> +++ b/package/uclibc/uclibc.mk
>> @@ -559,3 +559,5 @@ uclibc-menuconfig: dirs uclibc-patch
>>         rm -f
>> $(UCLIBC_DIR)/.stamp_{configured,built,target_installed,staging_installed}
>>
>>   $(eval $(generic-package))
>> +
>> +$(UCLIBC_TARGET_INSTALL_TARGET): $(UCLIBC_TARGET_INSTALL_STAGING)
>>
>
>  Same nitpick :-)

Same comment:
# The uclibc-install-target use files from uclibc-install-staging

Thanks and best regards

Patch

diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index dea36e7..c8eeb3d 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -559,3 +559,5 @@  uclibc-menuconfig: dirs uclibc-patch
 	rm -f $(UCLIBC_DIR)/.stamp_{configured,built,target_installed,staging_installed}
 
 $(eval $(generic-package))
+
+$(UCLIBC_TARGET_INSTALL_TARGET): $(UCLIBC_TARGET_INSTALL_STAGING)