| Message ID | 1382001897-2709-1-git-send-email-ezequiel.garcia@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Oct 17, 2013 at 06:24:57AM -0300, Ezequiel Garcia wrote: > In a recent commit: > > commit f455578dd961087a5cf94730d9f6489bb1d355f0 > Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > Date: Mon Aug 12 14:14:53 2013 -0300 > > mtd: nand: pxa3xx: Remove hardcoded mtd name > > There's no advantage in using a hardcoded name for the mtd device. > Instead use the provided by the platform_device. > > The MTD name was changed to use the one provided by the platform_device. > However, this can be problematic as some users want to set partitions > using the kernel parameter 'mtdpart', where the name is needed. > > For that reason, using a simpler and easier to remember name such > as 'pxa3xx-nand' is certainly a better choice. Hmm, if we're really interested in the user experience of 'mtdparts' users, shouldn't we just revert to the old name ("pxa3xx_nand-0") to avoid breaking systems? Or are there no users that would care? Brian
On Thu, Oct 17, 2013 at 06:36:18PM -0700, Brian Norris wrote: > On Thu, Oct 17, 2013 at 06:24:57AM -0300, Ezequiel Garcia wrote: > > In a recent commit: > > > > commit f455578dd961087a5cf94730d9f6489bb1d355f0 > > Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > > Date: Mon Aug 12 14:14:53 2013 -0300 > > > > mtd: nand: pxa3xx: Remove hardcoded mtd name > > > > There's no advantage in using a hardcoded name for the mtd device. > > Instead use the provided by the platform_device. > > > > The MTD name was changed to use the one provided by the platform_device. > > However, this can be problematic as some users want to set partitions > > using the kernel parameter 'mtdpart', where the name is needed. > > > > For that reason, using a simpler and easier to remember name such > > as 'pxa3xx-nand' is certainly a better choice. > > Hmm, if we're really interested in the user experience of 'mtdparts' > users, shouldn't we just revert to the old name ("pxa3xx_nand-0") to > avoid breaking systems? Or are there no users that would care? > Dammit! yes, that's the intention of this patch: revert to the old name "pxa3xx_nand-0" to avoid breaking systems. Guess I couldn't manage my OCD and picked a more appealing name :) I'll send a v2 right away.
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index aa75adf..6ec3810 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -46,6 +46,8 @@ */ #define INIT_BUFFER_SIZE 256 +#define DRIVER_NAME "pxa3xx-nand" + /* registers and bit definitions */ #define NDCR (0x00) /* Control register */ #define NDTR0CS0 (0x04) /* Timing Parameter 0 for CS0 */ @@ -1339,7 +1341,7 @@ static int pxa3xx_nand_probe(struct platform_device *pdev) for (cs = 0; cs < pdata->num_cs; cs++) { struct mtd_info *mtd = info->host[cs]->mtd; - mtd->name = pdev->name; + mtd->name = DRIVER_NAME; info->cs = cs; ret = pxa3xx_nand_scan(mtd); if (ret) { @@ -1425,7 +1427,7 @@ static int pxa3xx_nand_resume(struct platform_device *pdev) static struct platform_driver pxa3xx_nand_driver = { .driver = { - .name = "pxa3xx-nand", + .name = DRIVER_NAME, .of_match_table = pxa3xx_nand_dt_ids, }, .probe = pxa3xx_nand_probe,
In a recent commit: commit f455578dd961087a5cf94730d9f6489bb1d355f0 Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> Date: Mon Aug 12 14:14:53 2013 -0300 mtd: nand: pxa3xx: Remove hardcoded mtd name There's no advantage in using a hardcoded name for the mtd device. Instead use the provided by the platform_device. The MTD name was changed to use the one provided by the platform_device. However, this can be problematic as some users want to set partitions using the kernel parameter 'mtdpart', where the name is needed. For that reason, using a simpler and easier to remember name such as 'pxa3xx-nand' is certainly a better choice. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- drivers/mtd/nand/pxa3xx_nand.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)