Patchwork [RESEND,3/4] ARM: dts: bcm281xx: Add i2c busses

login
register
mail settings
Submitter Tim Kryger
Date Oct. 16, 2013, 10:01 p.m.
Message ID <1381960909-1735-4-git-send-email-tim.kryger@linaro.org>
Download mbox | patch
Permalink /patch/284039/
State Not Applicable
Headers show

Comments

Tim Kryger - Oct. 16, 2013, 10:01 p.m.
Add the DTS nodes for all the i2c busses in the SoC.

Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Christian Daudt <csd@broadcom.com>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
---
 arch/arm/boot/dts/bcm11351.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
Christian Daudt - Oct. 17, 2013, 4:32 a.m.
Hi Tim,
 This patch does not work as it relies on the yet-unmerged clock code
for bcm11351. This patch does not apply to -rc, and when tweaked it
does not compile as it references  non-existent bsc_clks.
 Has the clk patches been submitted yet ? Applying this will have to
wait until those have been accepted.

 thanks,
   csd


On Wed, Oct 16, 2013 at 3:01 PM, Tim Kryger <tim.kryger@linaro.org> wrote:
> Add the DTS nodes for all the i2c busses in the SoC.
>
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> ---
>  arch/arm/boot/dts/bcm11351.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index 1246885..4bfd7e3 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -146,6 +146,46 @@
>                 status = "disabled";
>         };
>
> +       i2c@3e016000 {
> +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +               reg = <0x3e016000 0x80>;
> +               interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               clocks = <&bsc1_clk>;
> +               status = "disabled";
> +       };
> +
> +       i2c@3e017000 {
> +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +               reg = <0x3e017000 0x80>;
> +               interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               clocks = <&bsc2_clk>;
> +               status = "disabled";
> +       };
> +
> +       i2c@3e018000 {
> +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +               reg = <0x3e018000 0x80>;
> +               interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               clocks = <&bsc3_clk>;
> +               status = "disabled";
> +       };
> +
> +       i2c@3500d000 {
> +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> +               reg = <0x3500d000 0x80>;
> +               interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               clocks = <&pmu_bsc_clk>;
> +               status = "disabled";
> +       };
> +
>         clocks {
>                 bsc1_clk: bsc1 {
>                         compatible = "fixed-clock";
> --
> 1.8.0.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Matt Porter - Oct. 17, 2013, 12:14 p.m.
On Wed, Oct 16, 2013 at 09:32:51PM -0700, Christian Daudt wrote:
> Hi Tim,
>  This patch does not work as it relies on the yet-unmerged clock code
> for bcm11351. This patch does not apply to -rc, and when tweaked it
> does not compile as it references  non-existent bsc_clks.
>  Has the clk patches been submitted yet ? Applying this will have to
> wait until those have been accepted.

Hi Christian, Tim mentioned the dependencies in the cover letter.
Sebastian's series, for which the pull request is already sent, and then
Tim's own fixed clock series that is pending some review.

-Matt

> On Wed, Oct 16, 2013 at 3:01 PM, Tim Kryger <tim.kryger@linaro.org> wrote:
> > Add the DTS nodes for all the i2c busses in the SoC.
> >
> > Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> > Reviewed-by: Christian Daudt <csd@broadcom.com>
> > Reviewed-by: Matt Porter <matt.porter@linaro.org>
> > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > ---
> >  arch/arm/boot/dts/bcm11351.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> > index 1246885..4bfd7e3 100644
> > --- a/arch/arm/boot/dts/bcm11351.dtsi
> > +++ b/arch/arm/boot/dts/bcm11351.dtsi
> > @@ -146,6 +146,46 @@
> >                 status = "disabled";
> >         };
> >
> > +       i2c@3e016000 {
> > +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> > +               reg = <0x3e016000 0x80>;
> > +               interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               clocks = <&bsc1_clk>;
> > +               status = "disabled";
> > +       };
> > +
> > +       i2c@3e017000 {
> > +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> > +               reg = <0x3e017000 0x80>;
> > +               interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               clocks = <&bsc2_clk>;
> > +               status = "disabled";
> > +       };
> > +
> > +       i2c@3e018000 {
> > +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> > +               reg = <0x3e018000 0x80>;
> > +               interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               clocks = <&bsc3_clk>;
> > +               status = "disabled";
> > +       };
> > +
> > +       i2c@3500d000 {
> > +               compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
> > +               reg = <0x3500d000 0x80>;
> > +               interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               clocks = <&pmu_bsc_clk>;
> > +               status = "disabled";
> > +       };
> > +
> >         clocks {
> >                 bsc1_clk: bsc1 {
> >                         compatible = "fixed-clock";
> > --
> > 1.8.0.1
> >
> >
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
index 1246885..4bfd7e3 100644
--- a/arch/arm/boot/dts/bcm11351.dtsi
+++ b/arch/arm/boot/dts/bcm11351.dtsi
@@ -146,6 +146,46 @@ 
 		status = "disabled";
 	};
 
+	i2c@3e016000 {
+		compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
+		reg = <0x3e016000 0x80>;
+		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&bsc1_clk>;
+		status = "disabled";
+	};
+
+	i2c@3e017000 {
+		compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
+		reg = <0x3e017000 0x80>;
+		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&bsc2_clk>;
+		status = "disabled";
+	};
+
+	i2c@3e018000 {
+		compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
+		reg = <0x3e018000 0x80>;
+		interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&bsc3_clk>;
+		status = "disabled";
+	};
+
+	i2c@3500d000 {
+		compatible = "brcm,bcm11351-i2c", "brcm,kona-i2c";
+		reg = <0x3500d000 0x80>;
+		interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&pmu_bsc_clk>;
+		status = "disabled";
+	};
+
 	clocks {
 		bsc1_clk: bsc1 {
 			compatible = "fixed-clock";