Patchwork wanxl: fix info leak in ioctl

login
register
mail settings
Submitter Salva Peiró
Date Oct. 16, 2013, 10:46 a.m.
Message ID <1381920411-16981-1-git-send-email-speiro@ai2.upv.es>
Download mbox | patch
Permalink /patch/283916/
State Accepted
Delegated to: David Miller
Headers show

Comments

Salva Peiró - Oct. 16, 2013, 10:46 a.m.
The wanxl_ioctl() code fails to initialize the two padding bytes of
struct sync_serial_settings after the ->loopback member. Add an explicit
memset(0) before filling the structure to avoid the info leak.

Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
---
 drivers/net/wan/wanxl.c |    1 +
 1 file changed, 1 insertion(+)

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index 6a24a5a..4c0a697 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -355,6 +355,7 @@  static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 			ifr->ifr_settings.size = size; /* data size wanted */
 			return -ENOBUFS;
 		}
+		memset(&line, 0, sizeof(line));
 		line.clock_type = get_status(port)->clocking;
 		line.clock_rate = 0;
 		line.loopback = 0;