Message ID | CAFULd4b_yJJ=DgjnqS+2gdjmfAxkrqhEnSsWekkk-wm9XDWbeg@mail.gmail.com |
---|---|
State | New |
Headers | show |
On Wed, Oct 16, 2013 at 12:24 AM, Uros Bizjak <ubizjak@gmail.com> wrote: > >> This patch to libgo fixes a dumb bug in which catching a signal via the >> os/signal package could clobber the saved split-stack context, leading >> to disaster if the signal arrived at the wrong time. Bootstrapped and >> ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. >> Will commit to 4.8 branch when it reopens. > > Attached patch is re-enables bootstrap on targets without split stack > due to unused variable warning. The patch was tested on > alphaev68-linux-gnu [1]. Whoops, sorry about that. Committed to mainline. Ian
Index: runtime/go-signal.c =================================================================== --- runtime/go-signal.c (revision 203610) +++ runtime/go-signal.c (working copy) @@ -399,7 +399,9 @@ { G *gp; M *mp; +#ifdef USING_SPLIT_STACK void *stack_context[10]; +#endif /* We are now running on the stack registered via sigaltstack. (Actually there is a small span of time between runtime_siginit