Patchwork [U-Boot,v2,1/2] serial: xuartlite: Staticize local functions

login
register
mail settings
Submitter Axel Lin
Date Oct. 16, 2013, 1:45 a.m.
Message ID <1381887956.9895.6.camel@phoenix>
Download mbox | patch
Permalink /patch/283811/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Axel Lin - Oct. 16, 2013, 1:45 a.m.
Staticize local functions in xuartlite driver.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2: Also staticize userial##port##_* functions

 drivers/serial/serial_xuartlite.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
Stefan Roese - Oct. 16, 2013, 6:18 a.m.
On 16.10.2013 03:45, Axel Lin wrote:
> Staticize local functions in xuartlite driver.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Michal Simek - Oct. 16, 2013, 6:56 a.m.
On 10/16/2013 08:18 AM, Stefan Roese wrote:
> On 16.10.2013 03:45, Axel Lin wrote:
>> Staticize local functions in xuartlite driver.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> Acked-by: Stefan Roese <sr@denx.de>

Tested-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal
Tom Rini - Nov. 8, 2013, 10:27 p.m.
On Wed, Oct 16, 2013 at 09:45:56AM +0800, Axel Lin wrote:

> Staticize local functions in xuartlite driver.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Stefan Roese <sr@denx.de>
> Tested-by: Michal Simek <monstr@monstr.eu>

Applied to u-boot/master, thanks!

Patch

diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
index 9c1d025..e613994 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -39,7 +39,7 @@  static struct uartlite *userial_ports[4] = {
 #endif
 };
 
-void uartlite_serial_putc(const char c, const int port)
+static void uartlite_serial_putc(const char c, const int port)
 {
 	struct uartlite *regs = userial_ports[port];
 
@@ -51,13 +51,13 @@  void uartlite_serial_putc(const char c, const int port)
 	out_be32(&regs->tx_fifo, c & 0xff);
 }
 
-void uartlite_serial_puts(const char *s, const int port)
+static void uartlite_serial_puts(const char *s, const int port)
 {
 	while (*s)
 		uartlite_serial_putc(*s++, port);
 }
 
-int uartlite_serial_getc(const int port)
+static int uartlite_serial_getc(const int port)
 {
 	struct uartlite *regs = userial_ports[port];
 
@@ -66,7 +66,7 @@  int uartlite_serial_getc(const int port)
 	return in_be32(&regs->rx_fifo) & 0xff;
 }
 
-int uartlite_serial_tstc(const int port)
+static int uartlite_serial_tstc(const int port)
 {
 	struct uartlite *regs = userial_ports[port];
 
@@ -82,16 +82,16 @@  static int uartlite_serial_init(const int port)
 
 /* Multi serial device functions */
 #define DECLARE_ESERIAL_FUNCTIONS(port) \
-	int userial##port##_init(void) \
+	static int userial##port##_init(void) \
 				{ return uartlite_serial_init(port); } \
-	void userial##port##_setbrg(void) {} \
-	int userial##port##_getc(void) \
+	static void userial##port##_setbrg(void) {} \
+	static int userial##port##_getc(void) \
 				{ return uartlite_serial_getc(port); } \
-	int userial##port##_tstc(void) \
+	static int userial##port##_tstc(void) \
 				{ return uartlite_serial_tstc(port); } \
-	void userial##port##_putc(const char c) \
+	static void userial##port##_putc(const char c) \
 				{ uartlite_serial_putc(c, port); } \
-	void userial##port##_puts(const char *s) \
+	static void userial##port##_puts(const char *s) \
 				{ uartlite_serial_puts(s, port); }
 
 /* Serial device descriptor */