| Message ID | 1381868190-8595-1-git-send-email-jgunthorpe@obsidianresearch.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Oct 15, 2013 at 02:16:30PM -0600, Jason Gunthorpe wrote: > There are no writable bits in the secondary status register, only > write 1 to clear bits. The driver never sets any of the write 1 to > clear bits so the status register should always be 0, just remove > the set from the write path. > > Someday the write 1 to clear bits should be copied/cleared directly > from registers in the HW. > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > --- > drivers/pci/host/pci-mvebu.c | 1 - > 1 file changed, 1 deletion(-) Applied to mvebu/drivers thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Jason Gunthorpe, On Tue, 15 Oct 2013 14:16:30 -0600, Jason Gunthorpe wrote: > There are no writable bits in the secondary status register, only > write 1 to clear bits. The driver never sets any of the write 1 to > clear bits so the status register should always be 0, just remove > the set from the write path. > > Someday the write 1 to clear bits should be copied/cleared directly > from registers in the HW. > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c index 09fc586..3e5cdbd 100644 --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c @@ -495,7 +495,6 @@ static int mvebu_sw_pci_bridge_write(struct mvebu_pcie_port *port, */ bridge->iobase = (value & 0xff) | PCI_IO_RANGE_TYPE_32; bridge->iolimit = ((value >> 8) & 0xff) | PCI_IO_RANGE_TYPE_32; - bridge->secondary_status = value >> 16; mvebu_pcie_handle_iobase_change(port); break;
There are no writable bits in the secondary status register, only write 1 to clear bits. The driver never sets any of the write 1 to clear bits so the status register should always be 0, just remove the set from the write path. Someday the write 1 to clear bits should be copied/cleared directly from registers in the HW. Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> --- drivers/pci/host/pci-mvebu.c | 1 - 1 file changed, 1 deletion(-)