| Message ID | 1381837514-50660-15-git-send-email-wangkefeng.wang@huawei.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 10/15/2013 03:45 PM, Kefeng Wang wrote: > net_ratelimited_function() is called to simplify code. > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/net/usb/usbnet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index bf94e10..edf81de 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -450,8 +450,8 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) > { > set_bit (work, &dev->flags); > if (!schedule_work (&dev->kevent)) { > - if (net_ratelimit()) > - netdev_err(dev->net, "kevent %d may have been dropped\n", work); > + net_ratelimited_function(netdev_err, dev->net, > + "kevent %d may have been dropped\n", work); The continuation line should start under 'netdev_err'. Same about the other patches where you didn't change the indentation of the continuation lines though you should have. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks for you reply. On 10/16 3:06, Sergei Shtylyov wrote: > Hello. > > On 10/15/2013 03:45 PM, Kefeng Wang wrote: > >> net_ratelimited_function() is called to simplify code. > >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >> --- >> drivers/net/usb/usbnet.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c >> index bf94e10..edf81de 100644 >> --- a/drivers/net/usb/usbnet.c >> +++ b/drivers/net/usb/usbnet.c >> @@ -450,8 +450,8 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) >> { >> set_bit (work, &dev->flags); >> if (!schedule_work (&dev->kevent)) { >> - if (net_ratelimit()) >> - netdev_err(dev->net, "kevent %d may have been dropped\n", work); >> + net_ratelimited_function(netdev_err, dev->net, >> + "kevent %d may have been dropped\n", work); > > The continuation line should start under 'netdev_err'. Same about the other patches where you didn't change the indentation of the continuation lines though you should have. Got it, indentation will be changed. > WBR, Sergei > > > . > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index bf94e10..edf81de 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -450,8 +450,8 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) { set_bit (work, &dev->flags); if (!schedule_work (&dev->kevent)) { - if (net_ratelimit()) - netdev_err(dev->net, "kevent %d may have been dropped\n", work); + net_ratelimited_function(netdev_err, dev->net, + "kevent %d may have been dropped\n", work); } else { netdev_dbg(dev->net, "kevent %d scheduled\n", work); }
net_ratelimited_function() is called to simplify code. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/net/usb/usbnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)