Patchwork [U-Boot] serial: mxs_auart: Staticize local functions

login
register
mail settings
Submitter Axel Lin
Date Oct. 15, 2013, 2:52 a.m.
Message ID <1381805555.19936.10.camel@phoenix>
Download mbox | patch
Permalink /patch/283449/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Axel Lin - Oct. 15, 2013, 2:52 a.m.
Staticize local functions in mxs_auart driver.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/serial/mxs_auart.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Marek Vasut - Oct. 15, 2013, 1:44 p.m.
Dear Axel Lin,

> Staticize local functions in mxs_auart driver.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Marek Vasut <marex@denx.de>

Just curious, how did you find this? Did you lint the files with some tool?

> ---
>  drivers/serial/mxs_auart.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/serial/mxs_auart.c b/drivers/serial/mxs_auart.c
> index 7cfe5bc..fc0fa96 100644
> --- a/drivers/serial/mxs_auart.c
> +++ b/drivers/serial/mxs_auart.c
> @@ -40,7 +40,7 @@ static struct mxs_uartapp_regs
> *get_uartapp_registers(void) * Sets the baud rate and settings.
>   * The settings are: 8 data bits, no parit and 1 stop bit.
>   */
> -void mxs_auart_setbrg(void)
> +static void mxs_auart_setbrg(void)
>  {
>  	u32 div;
>  	u32 linectrl = 0;
> @@ -77,7 +77,7 @@ void mxs_auart_setbrg(void)
>  	writel(linectrl, &regs->hw_uartapp_linectrl);
>  }
> 
> -int mxs_auart_init(void)
> +static int mxs_auart_init(void)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Reset everything */
> @@ -99,7 +99,7 @@ int mxs_auart_init(void)
>  	return 0;
>  }
> 
> -void mxs_auart_putc(const char c)
> +static void mxs_auart_putc(const char c)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Wait in loop while the transmit FIFO is full */
> @@ -112,14 +112,14 @@ void mxs_auart_putc(const char c)
>  		mxs_auart_putc('\r');
>  }
> 
> -int mxs_auart_tstc(void)
> +static int mxs_auart_tstc(void)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Checks if receive FIFO is empty */
>  	return !(readl(&regs->hw_uartapp_stat) & UARTAPP_STAT_RXFE_MASK);
>  }
> 
> -int mxs_auart_getc(void)
> +static int mxs_auart_getc(void)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Wait until a character is available to read */

Best regards,
Marek Vasut
Axel Lin - Oct. 16, 2013, 12:51 a.m.
2013/10/15 Marek Vasut <marex@denx.de>:
> Dear Axel Lin,
>
>> Staticize local functions in mxs_auart driver.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> Just curious, how did you find this? Did you lint the files with some tool?
I just read the code.

Regards,
Axel
Tom Rini - Nov. 8, 2013, 10:27 p.m.
On Tue, Oct 15, 2013 at 10:52:35AM +0800, Axel Lin wrote:
> Staticize local functions in mxs_auart driver.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot/master, thanks!

Patch

diff --git a/drivers/serial/mxs_auart.c b/drivers/serial/mxs_auart.c
index 7cfe5bc..fc0fa96 100644
--- a/drivers/serial/mxs_auart.c
+++ b/drivers/serial/mxs_auart.c
@@ -40,7 +40,7 @@  static struct mxs_uartapp_regs *get_uartapp_registers(void)
  * Sets the baud rate and settings.
  * The settings are: 8 data bits, no parit and 1 stop bit.
  */
-void mxs_auart_setbrg(void)
+static void mxs_auart_setbrg(void)
 {
 	u32 div;
 	u32 linectrl = 0;
@@ -77,7 +77,7 @@  void mxs_auart_setbrg(void)
 	writel(linectrl, &regs->hw_uartapp_linectrl);
 }
 
-int mxs_auart_init(void)
+static int mxs_auart_init(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Reset everything */
@@ -99,7 +99,7 @@  int mxs_auart_init(void)
 	return 0;
 }
 
-void mxs_auart_putc(const char c)
+static void mxs_auart_putc(const char c)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Wait in loop while the transmit FIFO is full */
@@ -112,14 +112,14 @@  void mxs_auart_putc(const char c)
 		mxs_auart_putc('\r');
 }
 
-int mxs_auart_tstc(void)
+static int mxs_auart_tstc(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Checks if receive FIFO is empty */
 	return !(readl(&regs->hw_uartapp_stat) & UARTAPP_STAT_RXFE_MASK);
 }
 
-int mxs_auart_getc(void)
+static int mxs_auart_getc(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Wait until a character is available to read */