| Message ID | 525C5DED.1080406@mojatatu.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jamal Hadi Salim <jhs@mojatatu.com> Date: Mon, 14 Oct 2013 17:11:09 -0400 > Trivial patch I know it seems rediculous, but anything we export to userspace, as we do in this UAPI header, could be potentially be used by some piece of source out there. I'd rather just leave it be, you can add a comment saying it's unused if you wish, but I'd really rather not remove it and run the risk of breaking someone's build out there. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
The only reason i made an exception of this one is because: a) nothing in the kernel touches it b) nothing in iproute2 touches it c) the intended logic to transport the hairpin knob is now in IFLA_BRPORT_MODE But: I empathize;-> Your call cheers, jamal On 10/17/13 16:10, David Miller wrote: > > > I know it seems rediculous, but anything we export to userspace, as we > do in this UAPI header, could be potentially be used by some piece of > source out there. > > I'd rather just leave it be, you can add a comment saying it's unused > if you wish, but I'd really rather not remove it and run the risk of > breaking someone's build out there. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index 80394e8..f8dab16 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -209,11 +209,6 @@ enum { #define IFLA_INET6_MAX (__IFLA_INET6_MAX - 1) enum { - BRIDGE_MODE_UNSPEC, - BRIDGE_MODE_HAIRPIN, -}; - -enum { IFLA_BRPORT_UNSPEC, IFLA_BRPORT_STATE, /* Spanning tree state */ IFLA_BRPORT_PRIORITY, /* " priority */
Trivial patch cheers, jamal commit 984b1bc7c51a1201707238f7aa5fa1a8b72fde90 Author: jamal <jhs@mojatatu.com> Date: Mon Oct 14 17:04:16 2013 -0400 Remove unused enum Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>