Patchwork [U-Boot] I2C:Zynq: Adapt this driver to the new model

login
register
mail settings
Submitter Michael Burr
Date Oct. 14, 2013, 4:25 p.m.
Message ID <EFBFAB0BC299D345A30F813A3C85DA87012790D5@EDPR-EX01.logicpd.com>
Download mbox | patch
Permalink /patch/283297/
State Changes Requested
Delegated to: Heiko Schocher
Headers show

Comments

Michael Burr - Oct. 14, 2013, 4:25 p.m.
CONFIGs and README for driver 'zynq_i2c.c'.

Signed-off-by: Michael Burr <michael.burr@logicpd.com>
Cc: Heiko Schocher<hs@denx.de>
Cc: Michal Simek<monstr@monstr.eu>

---
Heiko Schocher - Oct. 15, 2013, 5:59 a.m.
Hello Michal,

Am 14.10.2013 18:25, schrieb Michael Burr:
> CONFIGs and README for driver 'zynq_i2c.c'.
>
> Signed-off-by: Michael Burr<michael.burr@logicpd.com>
> Cc: Heiko Schocher<hs@denx.de>
> Cc: Michal Simek<monstr@monstr.eu>
>
> ---
>
> === This patch depends on the previous patch titled
> === "[PATCH] I2C:Zynq: Adapt this driver to the new model"
> === submitted 26 Sep. 2013.

please squash this patch into the above patch, and add the
rename of the drivers config define, and resubmit it, thanks!

bye,
Heiko
Jagannadha Sutradharudu Teki - Oct. 15, 2013, 12:05 p.m.
On Tue, Oct 15, 2013 at 11:29 AM, Heiko Schocher <hs@denx.de> wrote:
> Hello Michal,
>
>
> Am 14.10.2013 18:25, schrieb Michael Burr:
>>
>> CONFIGs and README for driver 'zynq_i2c.c'.
>>
>>
>> Signed-off-by: Michael Burr<michael.burr@logicpd.com>
>> Cc: Heiko Schocher<hs@denx.de>
>> Cc: Michal Simek<monstr@monstr.eu>
>>
>> ---
>>
>> === This patch depends on the previous patch titled
>> === "[PATCH] I2C:Zynq: Adapt this driver to the new model"
>> === submitted 26 Sep. 2013.
>
>
> please squash this patch into the above patch, and add the
> rename of the drivers config define, and resubmit it, thanks!

And also send the series again with  I2C: Zynq: Support for 0-length
register address
patch as v3 i guess, [you missed v2 patch version name]

Will update the status on testing these on zynq boards.
Michael Burr - Oct. 15, 2013, 5:19 p.m.
Jagan,

I am resending as you suggest -- except I used "v2", because it seems that Heiko made the previous versions of "[PATCH] I2C:Zynq: Adapt this driver to the new model" disappear from the list. Therefore the "v1" was this: "[PATCH] I2C: Zynq: Support for 0-length register address".

However, none of that really matters much, because all of the above has been collected into the series I'm (re)sending now.

Michael Burr  //  Software Engineer II

Logic PD
T // 612.436.7273
NOTICE: Important disclaimers and limitations apply to this email.
Please see this web page for our disclaimers and limitations:
http://logicpd.com/email-disclaimer/

-----Original Message-----
From: Jagan Teki [mailto:jagannadh.teki@gmail.com] 
Sent: Tuesday, October 15, 2013 7:05 AM
To: Heiko Schocher
Cc: Michael Burr; u-boot@lists.denx.de
Subject: Re: [U-Boot] [PATCH] I2C:Zynq: Adapt this driver to the new model

On Tue, Oct 15, 2013 at 11:29 AM, Heiko Schocher <hs@denx.de> wrote:
> Hello Michal,
>
>
> Am 14.10.2013 18:25, schrieb Michael Burr:
>>
>> CONFIGs and README for driver 'zynq_i2c.c'.
>>
>>
>> Signed-off-by: Michael Burr<michael.burr@logicpd.com>
>> Cc: Heiko Schocher<hs@denx.de>
>> Cc: Michal Simek<monstr@monstr.eu>
>>
>> ---
>>
>> === This patch depends on the previous patch titled
>> === "[PATCH] I2C:Zynq: Adapt this driver to the new model"
>> === submitted 26 Sep. 2013.
>
>
> please squash this patch into the above patch, and add the
> rename of the drivers config define, and resubmit it, thanks!

And also send the series again with  I2C: Zynq: Support for 0-length
register address
patch as v3 i guess, [you missed v2 patch version name]

Will update the status on testing these on zynq boards.

Patch

=== This patch depends on the previous patch titled
=== "[PATCH] I2C:Zynq: Adapt this driver to the new model"
=== submitted 26 Sep. 2013.

=== This patch depends on the previous patch titled
=== "[PATCH] I2C: Zynq: Support for 0-length register address"
=== submitted 24 Sep. 2013.

---
 README                 |    9 +++++++++
 include/configs/zynq.h |   10 ++++------
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/README b/README
index ccd47fa..fd2c8fc 100644
--- a/README
+++ b/README
@@ -1995,6 +1995,15 @@  CBFS (Coreboot Filesystem) support
 		  - CONFIG_SYS_I2C_PPC4XX_CH0 activate hardware channel 0
 		  - CONFIG_SYS_I2C_PPC4XX_CH1 activate hardware channel 1
 
+		- drivers/i2c/zynq_i2c.c
+		  - Activate this driver with CONFIG_SYS_I2C_ZYNQ
+		  - This driver operates only as bus-master (i.e. slave-
+		    address == 0) and supports only 100 kbps speed.
+		  - Both bus-controller devices in the Zynq PS (I2C0 and I2C1)
+		    are supported. (However, note that Zynq PL configuration 
+		    may be needed in order to route some bus lines to external
+		    pins.)
+
 		additional defines:
 
 		CONFIG_SYS_NUM_I2C_BUSES
diff --git a/include/configs/zynq.h b/include/configs/zynq.h
index b9f381f..1ae915f 100644
--- a/include/configs/zynq.h
+++ b/include/configs/zynq.h
@@ -56,15 +56,13 @@ 
 # define CONFIG_DOS_PARTITION
 #endif
 
-#define CONFIG_ZYNQ_I2C0
-
 /* I2C */
-#if defined(CONFIG_ZYNQ_I2C0) || defined(CONFIG_ZYNQ_I2C1)
+#define CONFIG_SYS_I2C_ZYNQ
+#ifdef CONFIG_SYS_I2C_ZYNQ
+# define CONFIG_SYS_I2C
 # define CONFIG_CMD_I2C
-# define CONFIG_ZYNQ_I2C
-# define CONFIG_HARD_I2C
 # define CONFIG_SYS_I2C_SPEED		100000
-# define CONFIG_SYS_I2C_SLAVE		1
+# define CONFIG_SYS_I2C_SLAVE		0
 #endif
 
 #if defined(CONFIG_ZYNQ_DCC)