Patchwork [3/3] i2c: i2c-core: fix coding style issues in i2c-core.c

login
register
mail settings
Submitter Raghavendra Ganiga
Date Oct. 14, 2013, 3:25 p.m.
Message ID <525C0CDB.6020305@gmail.com>
Download mbox | patch
Permalink /patch/283276/
State Rejected
Headers show

Comments

Raghavendra Ganiga - Oct. 14, 2013, 3:25 p.m.
From 2c324e677fd8bfb0ad13a8c949317e40cc5fd23e Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga <ravi23ganiga@gmail.com>
Date: Mon, 14 Oct 2013 20:42:37 +0530
Subject: [PATCH 3/3] i2c: i2c-core: fix coding style issues in i2c-core.c

This is a patch to the i2c-core.c file that fixes the
coding style issues found by checkpatch.pl tool

Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
---
 drivers/i2c/i2c-core.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Wolfram Sang - Jan. 14, 2014, 6:38 p.m.
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1737,9 +1737,9 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  		for (ret = 0; ret < num; ret++) {
>  			dev_dbg(&adap->dev, "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n",
>  				ret,
> -				((msgs[ret].flags & I2C_M_RD) ? 'R' : 'W'),
> +				msgs[ret].flags & I2C_M_RD ? 'R' : 'W',
>  				msgs[ret].addr, msgs[ret].len,
> -				(msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : "");
> +				msgs[ret].flags & I2C_M_RECV_LEN ? "+" : "");

Don't spend time changing too much here like the paranthesis. It will
probably be removed soon in favour of the tracing approach.

> @@ -2120,7 +2120,8 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
>  s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
>  {
>  	return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> -				I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
> +			      I2C_SMBUS_WRITE, value,
> +			      I2C_SMBUS_BYTE, NULL);

Not worth the change IMO. Just drop this patch.

Patch

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 66e38a9..7e95fcd 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1737,9 +1737,9 @@  int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 		for (ret = 0; ret < num; ret++) {
 			dev_dbg(&adap->dev, "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n",
 				ret,
-				((msgs[ret].flags & I2C_M_RD) ? 'R' : 'W'),
+				msgs[ret].flags & I2C_M_RD ? 'R' : 'W',
 				msgs[ret].addr, msgs[ret].len,
-				(msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : "");
+				msgs[ret].flags & I2C_M_RECV_LEN ? "+" : "");
 		}
 #endif
 
@@ -2120,7 +2120,8 @@  EXPORT_SYMBOL(i2c_smbus_read_byte);
 s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
 {
 	return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
-				I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
+			      I2C_SMBUS_WRITE, value,
+			      I2C_SMBUS_BYTE, NULL);
 }
 EXPORT_SYMBOL(i2c_smbus_write_byte);