Patchwork ARM: CCI : Fix implicit declaration of function error

login
register
mail settings
Submitter Majunath Goudar
Date Oct. 14, 2013, 10:22 a.m.
Message ID <1381746147-13830-1-git-send-email-manju.goudar@lge.com>
Download mbox | patch
Permalink /patch/283171/
State New
Headers show

Comments

Majunath Goudar - Oct. 14, 2013, 10:22 a.m.
This patch adds a inline dummy implementations of_find_matching_node()
in "#ifdef CONFIG_OF" else part. Without this patch,build system can
lead to issues. This was discovered during randconfig testing,in which
ARM_CCI was enabled w/o CONFIG_OF being enabled,leading to the following error:

CC      drivers/bus/arm-cci.o
drivers/bus/arm-cci.c: In function ‘cci_probe’:
drivers/bus/arm-cci.c:971:2: error: implicit declaration of function
‘of_find_matching_node’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/bus/arm-cci.o] Error 1
make[1]: *** [drivers/bus] Error 2
make: *** [drivers] Error 2

Signed-off-by: Manjunath Goudar <manju.goudar@lge.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 include/linux/of.h |    7 +++++++
 1 file changed, 7 insertions(+)

Patch

diff --git a/include/linux/of.h b/include/linux/of.h
index f95aee3..2c57aa2 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -340,6 +340,13 @@  int of_device_is_stdout_path(struct device_node *dn);
 
 #else /* CONFIG_OF */
 
+static inline struct device_node *of_find_matching_node(
+	struct device_node *from,
+	const struct of_device_id *matches)
+{
+	return NULL;
+}
+
 static inline const char* of_node_full_name(struct device_node *np)
 {
 	return "<no-node>";