From patchwork Sat Oct 12 07:13:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 282984 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id B69E42C0398 for ; Sat, 12 Oct 2013 18:13:51 +1100 (EST) Received: from mail-bk0-x231.google.com (mail-bk0-x231.google.com [IPv6:2a00:1450:4008:c01::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C788D2C034F for ; Sat, 12 Oct 2013 18:13:24 +1100 (EST) Received: by mail-bk0-f49.google.com with SMTP id r7so1890940bkg.36 for ; Sat, 12 Oct 2013 00:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=8VQwwzoftYWe2BKxROkwrSLVkGAilRhB2SQ5XP4Jjec=; b=Bry29p7kIm9Py3JGpdtuvZgGY3ICxTvd48rPORjvRl1c/N18ElRq6oafJEvqBzqMkx ixDtZ3f0Gb9aA27dkmGaF+KlP24MRity4G3wdtwmcYPVxgmpBru1d2FOWWvML4rhNgMA i5jCBcTA2y/eLa/2RJLV4Y1wSeQ1bPDWlDTDWzzdaXhzmnE0GvEiMT06eim94r1rIopY qtHfK9SKHClJ/lQcdxCeNScvWT1iuju68YuUHKlpNkj7FU5v45NZUmDq+G4PG8g40IKx SdE8X2Ls65eBbq9YFzrB3ZfTNi0TCJ0OKxSbiAkuo+o6d6vg4BFJGIn+M2x9ME+lkVa3 kCRA== MIME-Version: 1.0 X-Received: by 10.204.227.140 with SMTP id ja12mr32862bkb.29.1381561999695; Sat, 12 Oct 2013 00:13:19 -0700 (PDT) Received: by 10.205.19.10 with HTTP; Sat, 12 Oct 2013 00:13:19 -0700 (PDT) Date: Sat, 12 Oct 2013 15:13:19 +0800 Message-ID: Subject: [PATCH] ppc-6xx: add missing iounmap() on error in hlwd_pic_init() From: Wei Yongjun To: benh@kernel.crashing.org, paulus@samba.org, grant.likely@linaro.org, rob.herring@calxeda.com Cc: yongjun_wei@trendmicro.com.cn, linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16rc2 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Wei Yongjun Add the missing iounmap() before return from hlwd_pic_init() in the error handling case. Signed-off-by: Wei Yongjun --- arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c index 7cab21d..6c03034 100644 --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c @@ -183,6 +183,7 @@ struct irq_domain *hlwd_pic_init(struct device_node *np) &hlwd_irq_domain_ops, io_base); if (!irq_domain) { pr_err("failed to allocate irq_domain\n"); + iounmap(io_base); return NULL; }