Patchwork Add --enable-host-shared configuration option

login
register
mail settings
Submitter David Malcolm
Date Oct. 11, 2013, 8:24 p.m.
Message ID <1381523083.30976.76.camel@surprise>
Download mbox | patch
Permalink /patch/282930/
State New
Headers show

Comments

David Malcolm - Oct. 11, 2013, 8:24 p.m.
On Thu, 2013-10-10 at 01:05 +0000, Joseph S. Myers wrote:
> On Wed, 9 Oct 2013, David Malcolm wrote:
> 
> > This patch adds an "--enable-host-shared" option throughout the various
> > configure/Make machinery for host code, adding "-fPIC" where appropriate
> > when enabled.
> 
> Please document this in install.texi (even if it isn't particularly useful 
> at the stage where it just means PIC rather than actual shared libraries).

How does the following look:

gcc/
	* doc/install.texi (--enable-shared): Add note contrasting it
	with...
	(--enable-host-shared): ...new option.
Joseph S. Myers - Oct. 11, 2013, 8:45 p.m.
On Fri, 11 Oct 2013, David Malcolm wrote:

> On Thu, 2013-10-10 at 01:05 +0000, Joseph S. Myers wrote:
> > On Wed, 9 Oct 2013, David Malcolm wrote:
> > 
> > > This patch adds an "--enable-host-shared" option throughout the various
> > > configure/Make machinery for host code, adding "-fPIC" where appropriate
> > > when enabled.
> > 
> > Please document this in install.texi (even if it isn't particularly useful 
> > at the stage where it just means PIC rather than actual shared libraries).
> 
> How does the following look:
> 
> gcc/
> 	* doc/install.texi (--enable-shared): Add note contrasting it
> 	with...
> 	(--enable-host-shared): ...new option.

Seems reasonable to me.
David Malcolm - Oct. 11, 2013, 8:49 p.m.
On Fri, 2013-10-11 at 20:45 +0000, Joseph S. Myers wrote:
> On Fri, 11 Oct 2013, David Malcolm wrote:
> 
> > On Thu, 2013-10-10 at 01:05 +0000, Joseph S. Myers wrote:
> > > On Wed, 9 Oct 2013, David Malcolm wrote:
> > > 
> > > > This patch adds an "--enable-host-shared" option throughout the various
> > > > configure/Make machinery for host code, adding "-fPIC" where appropriate
> > > > when enabled.
> > > 
> > > Please document this in install.texi (even if it isn't particularly useful 
> > > at the stage where it just means PIC rather than actual shared libraries).
> > 
> > How does the following look:
> > 
> > gcc/
> > 	* doc/install.texi (--enable-shared): Add note contrasting it
> > 	with...
> > 	(--enable-host-shared): ...new option.
> 
> Seems reasonable to me.

Thanks.   Presumably the initially posted configure/make patch still
needs review, right?

Dave
Joseph S. Myers - Oct. 11, 2013, 11:20 p.m.
On Fri, 11 Oct 2013, David Malcolm wrote:

> Thanks.   Presumably the initially posted configure/make patch still
> needs review, right?

Yes (by a build system maintainer, probably).
Jeff Law - Oct. 15, 2013, 4:17 p.m.
On 10/11/13 14:49, David Malcolm wrote:
> On Fri, 2013-10-11 at 20:45 +0000, Joseph S. Myers wrote:
>> On Fri, 11 Oct 2013, David Malcolm wrote:
>>
>>> On Thu, 2013-10-10 at 01:05 +0000, Joseph S. Myers wrote:
>>>> On Wed, 9 Oct 2013, David Malcolm wrote:
>>>>
>>>>> This patch adds an "--enable-host-shared" option throughout the various
>>>>> configure/Make machinery for host code, adding "-fPIC" where appropriate
>>>>> when enabled.
>>>>
>>>> Please document this in install.texi (even if it isn't particularly useful
>>>> at the stage where it just means PIC rather than actual shared libraries).
>>>
>>> How does the following look:
>>>
>>> gcc/
>>> 	* doc/install.texi (--enable-shared): Add note contrasting it
>>> 	with...
>>> 	(--enable-host-shared): ...new option.
>>
>> Seems reasonable to me.
>
> Thanks.   Presumably the initially posted configure/make patch still
> needs review, right?
Yes.  I'm looking at it now.
jeff

Patch

commit 23bf2a4389817352bca1bdcbe3d7971b4f607e4b
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Fri Oct 11 16:22:45 2013 -0400

    Document --enable-host-shared
    
    gcc/
    	* doc/install.texi (--enable-shared): Add note contrasting it
    	with...
    	(--enable-host-shared): New option.

diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 7be8e5a..5cb4d3c 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -925,6 +925,19 @@  Use @option{--disable-shared} to build only static libraries.  Note that
 @option{--disable-shared} does not accept a list of package names as
 argument, only @option{--enable-shared} does.
 
+Contrast with @option{--enable-host-shared}, which affects @emph{host}
+code.
+
+@item --enable-host-shared
+Specify that the @emph{host} code should be built into position-independent
+machine code (with -fPIC), allowing it to be used within shared libraries,
+but yielding a slightly slower compiler.
+
+Currently this option is only of use to people developing GCC itself.
+
+Contrast with @option{--enable-shared}, which affects @emph{target}
+libraries.
+
 @item @anchor{with-gnu-as}--with-gnu-as
 Specify that the compiler should assume that the
 assembler it finds is the GNU assembler.  However, this does not modify