diff mbox

[1/2,v3] netdev: smsc911x: allow building on any system

Message ID 1244538819-11305-1-git-send-email-vapier@gentoo.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Mike Frysinger June 9, 2009, 9:13 a.m. UTC
The smsc911x driver should build fine on any system as it contains no arch
specific code (all platform resources), and any platform that has
appropriate resources should run fine.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v3
	- based on net-next

 drivers/net/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

David Miller June 9, 2009, 10:59 a.m. UTC | #1
From: Mike Frysinger <vapier@gentoo.org>
Date: Tue,  9 Jun 2009 05:13:39 -0400

> The smsc911x driver should build fine on any system as it contains no arch
> specific code (all platform resources), and any platform that has
> appropriate resources should run fine.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Where is patch 2/2 :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mike Frysinger June 9, 2009, 11:08 a.m. UTC | #2
On Tue, Jun 9, 2009 at 06:59, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
>> The smsc911x driver should build fine on any system as it contains no arch
>> specific code (all platform resources), and any platform that has
>> appropriate resources should run fine.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Where is patch 2/2 :-)

meh, call this patch 1.5 since it doesnt replace the previous 1/2 like
v2 did.  there is no 2/2.
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller June 9, 2009, 12:21 p.m. UTC | #3
From: Mike Frysinger <vapier@gentoo.org>
Date: Tue,  9 Jun 2009 05:13:39 -0400

> The smsc911x driver should build fine on any system as it contains no arch
> specific code (all platform resources), and any platform that has
> appropriate resources should run fine.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller June 9, 2009, 12:23 p.m. UTC | #4
From: David Miller <davem@davemloft.net>
Date: Tue, 09 Jun 2009 05:21:36 -0700 (PDT)

> From: Mike Frysinger <vapier@gentoo.org>
> Date: Tue,  9 Jun 2009 05:13:39 -0400
> 
>> The smsc911x driver should build fine on any system as it contains no arch
>> specific code (all platform resources), and any platform that has
>> appropriate resources should run fine.
>> 
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> Applied.

Actually, I have to revert.

Not all platforms implement writesl(), readsl(), etc.
The build failed on sparc64, for example.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 962b261..8c92abd 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1000,7 +1000,6 @@  config SMC911X
 
 config SMSC911X
 	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
-	depends on ARM || SUPERH || BLACKFIN
 	select CRC32
 	select MII
 	select PHYLIB