Patchwork [U-Boot] imx: Easy enabling of SION per-pin using MUX_MODE_SION helper macro

login
register
mail settings
Submitter Otavio Salvador
Date Oct. 11, 2013, 1:31 a.m.
Message ID <1381455097-27960-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/282507/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Otavio Salvador - Oct. 11, 2013, 1:31 a.m.
The macro allows easy setting in per-pin, as for example:

,----
| imx_iomux_v3_setup_pad(MX6_PAD_NANDF_D1__GPIO_2_1 | MUX_MODE_SION);
`----

The IOMUX_CONFIG_SION allows for reading PAD value from PSR register.

The following quote from the datasheet:

,----
| ...
| 28.4.2.2 GPIO Write Mode
| The programming sequence for driving output signals should be as follows:
| 1. Configure IOMUX to select GPIO mode (Via IOMUXC), also enable SION if need
| to read loopback pad value through PSR
| 2. Configure GPIO direction register to output (GPIO_GDIR[GDIR] set to 1b).
| 3. Write value to data register (GPIO_DR).
| ...
`----

This fixes the gpio_get_value to properly work when a GPIO is set for
output and has no conflicts.

Thanks for Benoît Thébaudeau <benoit.thebaudeau@advansee.com>, Fabio
Estevam <fabio.estevam@freescale.com> and Eric Bénard
<eric@eukrea.com> for helping to properly trace this down.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- Fix too long line
- Move it just before MUX_PAD_CTRL(x)

 arch/arm/include/asm/imx-common/iomux-v3.h | 2 ++
 1 file changed, 2 insertions(+)
Marek Vasut - Oct. 11, 2013, 2:14 a.m.
Dear Otavio Salvador,

> The macro allows easy setting in per-pin, as for example:
> 
> ,----
> 
> | imx_iomux_v3_setup_pad(MX6_PAD_NANDF_D1__GPIO_2_1 | MUX_MODE_SION);
> 
> `----
> 
> The IOMUX_CONFIG_SION allows for reading PAD value from PSR register.
> 
> The following quote from the datasheet:

I think I already saw this patch. Is this a V2? Or a repost?

Best regards,
Marek Vasut
Otavio Salvador - Oct. 11, 2013, 2:38 a.m.
On Thu, Oct 10, 2013 at 11:14 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
>> The macro allows easy setting in per-pin, as for example:
>>
>> ,----
>>
>> | imx_iomux_v3_setup_pad(MX6_PAD_NANDF_D1__GPIO_2_1 | MUX_MODE_SION);
>>
>> `----
>>
>> The IOMUX_CONFIG_SION allows for reading PAD value from PSR register.
>>
>> The following quote from the datasheet:
>
> I think I already saw this patch. Is this a V2? Or a repost?

This is the v2; my fault of bad tagging it.

Patch

diff --git a/arch/arm/include/asm/imx-common/iomux-v3.h b/arch/arm/include/asm/imx-common/iomux-v3.h
index dc2b3ef..dec11a1 100644
--- a/arch/arm/include/asm/imx-common/iomux-v3.h
+++ b/arch/arm/include/asm/imx-common/iomux-v3.h
@@ -63,6 +63,8 @@  typedef u64 iomux_v3_cfg_t;
 #define MUX_SEL_INPUT_SHIFT	59
 #define MUX_SEL_INPUT_MASK	((iomux_v3_cfg_t)0xf << MUX_SEL_INPUT_SHIFT)
 
+#define MUX_MODE_SION		((iomux_v3_cfg_t)IOMUX_CONFIG_SION << \
+	MUX_MODE_SHIFT)
 #define MUX_PAD_CTRL(x)		((iomux_v3_cfg_t)(x) << MUX_PAD_CTRL_SHIFT)
 
 #define IOMUX_PAD(pad_ctrl_ofs, mux_ctrl_ofs, mux_mode, sel_input_ofs,	\