From patchwork Thu Oct 10 14:19:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Picco X-Patchwork-Id: 282270 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 199992C00D0 for ; Fri, 11 Oct 2013 01:15:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032Ab3JJOPH (ORCPT ); Thu, 10 Oct 2013 10:15:07 -0400 Received: from caiajhbdcaid.dreamhost.com ([208.97.132.83]:35501 "EHLO homiemail-a88.g.dreamhost.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752911Ab3JJOPG (ORCPT ); Thu, 10 Oct 2013 10:15:06 -0400 Received: from homiemail-a88.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a88.g.dreamhost.com (Postfix) with ESMTP id A2163264079; Thu, 10 Oct 2013 07:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=meloft.net; h=date:from:to :cc:subject:message-id:references:mime-version:content-type: in-reply-to; s=meloft.net; bh=Cq/7BINlmm441cNbtzdM5tnsU2U=; b=Sd LfMWllRWjyZlVWaQ56Ow3hpRr75UOVFjRelP2bZ2HXOW/s1hZ/BeXirNphY/hd+8 nYKLas500keGcEuxvV58R8AL4tAqrMxEAzZNO4hMCc6Bv1e0jSW04izoZtmOxKd+ SvIL2Ja3WTAZjK66YZyGdde2VL1FvtlXkJHGzsCno= Received: from meloft.net (c-50-136-7-79.hsd1.nh.comcast.net [50.136.7.79]) (Authenticated sender: bpicco@meloft.net) by homiemail-a88.g.dreamhost.com (Postfix) with ESMTPA id 1A64926406C; Thu, 10 Oct 2013 07:15:03 -0700 (PDT) Received: by meloft.net (sSMTP sendmail emulation); Thu, 10 Oct 2013 10:19:06 -0400 Date: Thu, 10 Oct 2013 10:19:06 -0400 From: Bob Picco To: David Miller Cc: bpicco@meloft.net, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 0/9] sparc64: Support 47-bit physical addresses. Message-ID: <20131010141906.GP29427@zareason> References: <20130930.123130.354302574443157859.davem@davemloft.net> <20131004154555.GL29427@zareason> <20131009.160309.793422921861188128.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131009.160309.793422921861188128.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org David Miller wrote: [Wed Oct 09 2013, 04:03:09PM EDT] > From: Bob Picco > Date: Fri, 4 Oct 2013 11:45:55 -0400 > > > The issue appears to be corruption. > > I think I know what the problem is. > > In set_pmd_at() we need to flush two 4MB pages. > > I'll play around with your test case and a potential fix, thanks. I believe you need this too. Otherwise the wrong tsb is computed. arch/sparc/mm/init_64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 4d0c99b..807e108 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2722,7 +2722,7 @@ void update_mmu_cache_pmd(struct vm_area_struct *vma, unsigned long addr, spin_lock_irqsave(&mm->context.lock, flags); if (mm->context.tsb_block[MM_TSB_HUGE].tsb != NULL) - __update_mmu_tsb_insert(mm, MM_TSB_HUGE, HPAGE_SHIFT, + __update_mmu_tsb_insert(mm, MM_TSB_HUGE, REAL_HPAGE_SHIFT, addr, pte); spin_unlock_irqrestore(&mm->context.lock, flags);