Patchwork nand/s3c2410: s3c2410_nand_setrate(): use correct macros for 2412/2440

login
register
mail settings
Submitter Peter Korsgaard
Date June 7, 2009, 1:04 p.m.
Message ID <1244379863-23581-1-git-send-email-jacmet@sunsite.dk>
Download mbox | patch
Permalink /patch/28201/
State New, archived
Headers show

Comments

Peter Korsgaard - June 7, 2009, 1:04 p.m.
Use the correct S3C2440_NFCONF_* macros for the mask for the 2412/2440
variants instead of the 2410 ones which use wrong bit positions.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 drivers/mtd/nand/s3c2410.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Artem Bityutskiy - June 8, 2009, 5:28 a.m.
On Sun, 2009-06-07 at 15:04 +0200, Peter Korsgaard wrote:
> Use the correct S3C2440_NFCONF_* macros for the mask for the 2412/2440
> variants instead of the 2410 ones which use wrong bit positions.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

Your patch is already in the mtd-2.6.git tree.
Peter Korsgaard - June 8, 2009, 5:38 a.m.
>>>>> "Artem" == Artem Bityutskiy <dedekind@infradead.org> writes:

 Artem> On Sun, 2009-06-07 at 15:04 +0200, Peter Korsgaard wrote:
 >> Use the correct S3C2440_NFCONF_* macros for the mask for the 2412/2440
 >> variants instead of the 2410 ones which use wrong bit positions.
 >> 
 >> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

 Artem> Your patch is already in the mtd-2.6.git tree.

Ahh, sorry - Missed that. I resent it as it is a prerequisite to the
s3c64xx support to the driver I sent yesterday.

That patch seems to have never made it to the list though, so I will
resend.
Artem Bityutskiy - June 8, 2009, 5:47 a.m.
On Mon, 2009-06-08 at 07:38 +0200, Peter Korsgaard wrote:
> >>>>> "Artem" == Artem Bityutskiy <dedekind@infradead.org> writes:
> 
>  Artem> On Sun, 2009-06-07 at 15:04 +0200, Peter Korsgaard wrote:
>  >> Use the correct S3C2440_NFCONF_* macros for the mask for the 2412/2440
>  >> variants instead of the 2410 ones which use wrong bit positions.
>  >> 
>  >> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> 
>  Artem> Your patch is already in the mtd-2.6.git tree.
> 
> Ahh, sorry - Missed that. I resent it as it is a prerequisite to the
> s3c64xx support to the driver I sent yesterday.
> 
> That patch seems to have never made it to the list though, so I will
> resend.

It was trapped, but now approved.
Peter Korsgaard - June 8, 2009, 6:32 a.m.
>>>>> "Artem" == Artem Bityutskiy <dedekind@infradead.org> writes:

Hi,

 >> That patch seems to have never made it to the list though, so I
 >> will resend.

 Artem> It was trapped, but now approved.

Thanks. What did I do wrong to get it trapped?
Artem Bityutskiy - June 8, 2009, 6:41 a.m.
On Mon, 2009-06-08 at 08:32 +0200, Peter Korsgaard wrote:
> >>>>> "Artem" == Artem Bityutskiy <dedekind@infradead.org> writes:
> 
> Hi,
> 
>  >> That patch seems to have never made it to the list though, so I
>  >> will resend.
> 
>  Artem> It was trapped, but now approved.
> 
> Thanks. What did I do wrong to get it trapped?

"Re in subject but no in-reply-to". dwmw2 was going to fix this
few years ago :-)
David Woodhouse - June 8, 2009, 7:51 a.m.
On Sun, 2009-06-07 at 23:41 -0700, Artem Bityutskiy wrote:
> 
> "Re in subject but no in-reply-to". dwmw2 was going to fix this
> few years ago :-)

Other way round, surely. It's the thread-hijack check, which checks for
messages with In-Reply-To: or References: headers indicating that
they're a reply to an existing thread, but without 'Re:' or 'Aw:' in the
Subject: header.

In the years since I implemented that basic netiquette check, it's
become acceptable to do exactly that for patch sequences. I thought I'd
fixed it to accept 'PATCH' as well as 'Re:' and 'Aw:', but on looking
closer I see I screwed it up -- it was trying to do a case-insensitive
compare by turning the subject header into lower case before the 
comparison.... and then comparing against 'PATCH' in upper case... :)

Fixed now:
http://git.infradead.org/users/dwmw2/eximconf.git?a=commitdiff;h=47505756
Peter Korsgaard - June 8, 2009, 7:54 a.m.
>>>>> "David" == David Woodhouse <dwmw2@infradead.org> writes:

Hi,

 David> In the years since I implemented that basic netiquette check,
 David> it's become acceptable to do exactly that for patch
 David> sequences. I thought I'd fixed it to accept 'PATCH' as well as
 David> 'Re:' and 'Aw:', but on looking closer I see I screwed it up
 David> -- it was trying to do a case-insensitive compare by turning
 David> the subject header into lower case before the
 David> comparison.... and then comparing against 'PATCH' in upper
 David> case... :)

Thanks!
Ben Dooks - June 8, 2009, 11:20 a.m.
On Sun, Jun 07, 2009 at 03:04:22PM +0200, Peter Korsgaard wrote:
> Use the correct S3C2440_NFCONF_* macros for the mask for the 2412/2440
> variants instead of the 2410 ones which use wrong bit positions.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
>  drivers/mtd/nand/s3c2410.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
> index 89b7905..01a105e 100644
> --- a/drivers/mtd/nand/s3c2410.c
> +++ b/drivers/mtd/nand/s3c2410.c
> @@ -253,9 +253,9 @@ static int s3c2410_nand_setrate(struct s3c2410_nand_info *info)
>  
>  	case TYPE_S3C2440:
>  	case TYPE_S3C2412:
> -		mask = (S3C2410_NFCONF_TACLS(tacls_max - 1) |
> -			S3C2410_NFCONF_TWRPH0(7) |
> -			S3C2410_NFCONF_TWRPH1(7));
> +		mask = (S3C2440_NFCONF_TACLS(tacls_max - 1) |
> +			S3C2440_NFCONF_TWRPH0(7) |
> +			S3C2440_NFCONF_TWRPH1(7));
>  
>  		set = S3C2440_NFCONF_TACLS(tacls - 1);
>  		set |= S3C2440_NFCONF_TWRPH0(twrph0 - 1);
> -- 
> 1.6.2
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Patch

diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 89b7905..01a105e 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -253,9 +253,9 @@  static int s3c2410_nand_setrate(struct s3c2410_nand_info *info)
 
 	case TYPE_S3C2440:
 	case TYPE_S3C2412:
-		mask = (S3C2410_NFCONF_TACLS(tacls_max - 1) |
-			S3C2410_NFCONF_TWRPH0(7) |
-			S3C2410_NFCONF_TWRPH1(7));
+		mask = (S3C2440_NFCONF_TACLS(tacls_max - 1) |
+			S3C2440_NFCONF_TWRPH0(7) |
+			S3C2440_NFCONF_TWRPH1(7));
 
 		set = S3C2440_NFCONF_TACLS(tacls - 1);
 		set |= S3C2440_NFCONF_TWRPH0(twrph0 - 1);