From patchwork Sat Jun  6 01:45:53 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [MTD-UTILS] Incorrect loop condition
Date: Fri, 05 Jun 2009 15:45:53 -0000
From: Jehan Bing <jehan@orb.com>
X-Patchwork-Id: 28177
Message-Id: <4A29CA51.1070906@orb.com>
To: linux-mtd@lists.infradead.org

Small patch to fix an obvious typo.

If the file contains only a few bytes in the last page and the --oob option is selected, the loop may exit early (readlen < meminfo.oobsize).
Most of the time it will still work though because the code tries to read the whole OOB in one chunk.

Signed-off-by: Jehan Bing <jehan@orb.com>


--- a/nandwrite.c	2009-06-01 18:03:55.000000000 -0700
+++ b/nandwrite.c	2009-06-05 18:32:56.000000000 -0700
@@ -531,7 +531,7 @@ int main(int argc, char * const argv[])
 		if (writeoob) {
 			int tinycnt = 0;
 
-			while(tinycnt < readlen) {
+			while(tinycnt < meminfo.oobsize) {
 				cnt = read(ifd, oobreadbuf + tinycnt, meminfo.oobsize - tinycnt);
 				if (cnt == 0) { // EOF
 					break;