[06/11] package/weston: fix configure.ac to check for wayland-scanner

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

configure whines while checking for wayland-scanner.

wayland-scanner is used to generate the protocol parser C files from
the protocol definition XML files.

weston has a hard-dependency on wayland-scanner, so it can regenerate
its shell/mouse/keyboard/... "handlers".

Since we're using a tarball, those protocol files are already generated
and up-to-date, but the check is hard-coded and unconditional. If
wayland-scanner is missing, configure fails.

wayland-scanner is provided by wayland, so we'd have to have a
host-wayland if we want wayland scanner.

We could well patch away this check, but we'd have to carry and maintain
it probably for ever.

Better to fix it, and introduce a host-wayland. Make weston depend on
host-wayland. Add a patch from upstream weston to fix configure whining.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/wayland/wayland.mk                         |  1 +
 ...02-fix-configure.ac-check-wayland-scanner.patch | 26 ++++++++++++++++++++++
 package/weston/weston.mk                           |  8 +++++--
 3 files changed, 33 insertions(+), 2 deletions(-)
 create mode 100644 package/weston/weston-0002-fix-configure.ac-check-wayland-scanner.patch

Dear Yann E. MORIN,

On Wed,  9 Oct 2013 00:09:52 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> configure whines while checking for wayland-scanner.
> 
> wayland-scanner is used to generate the protocol parser C files from
> the protocol definition XML files.
> 
> weston has a hard-dependency on wayland-scanner, so it can regenerate
> its shell/mouse/keyboard/... "handlers".
> 
> Since we're using a tarball, those protocol files are already generated
> and up-to-date, but the check is hard-coded and unconditional. If
> wayland-scanner is missing, configure fails.
> 
> wayland-scanner is provided by wayland, so we'd have to have a
> host-wayland if we want wayland scanner.
> 
> We could well patch away this check, but we'd have to carry and maintain
> it probably for ever.
> 
> Better to fix it, and introduce a host-wayland. Make weston depend on
> host-wayland. Add a patch from upstream weston to fix configure whining.

Huh? wayland.mk does build wayland-scanner with the native compiler
before starting the build itself. It doesn't work anymore with 1.2.x ?

Thomas

Thomas, All,

On 2013-10-09 00:15 +0200, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> On Wed,  9 Oct 2013 00:09:52 +0200, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > configure whines while checking for wayland-scanner.
> > 
> > wayland-scanner is used to generate the protocol parser C files from
> > the protocol definition XML files.
> > 
> > weston has a hard-dependency on wayland-scanner, so it can regenerate
> > its shell/mouse/keyboard/... "handlers".
> > 
> > Since we're using a tarball, those protocol files are already generated
> > and up-to-date, but the check is hard-coded and unconditional. If
> > wayland-scanner is missing, configure fails.
> > 
> > wayland-scanner is provided by wayland, so we'd have to have a
> > host-wayland if we want wayland scanner.
> > 
> > We could well patch away this check, but we'd have to carry and maintain
> > it probably for ever.
> > 
> > Better to fix it, and introduce a host-wayland. Make weston depend on
> > host-wayland. Add a patch from upstream weston to fix configure whining.
> 
> Huh? wayland.mk does build wayland-scanner with the native compiler
> before starting the build itself. It doesn't work anymore with 1.2.x ?

He! I did not even check... Yes, it does.
I basically did not expect wayland to build host tools.

I'll rework the series so wayland installs wayland-scanner to $(HOST),
and use that instead of host-wayland.

Thanks! 

Regards,
Yann E. MORIN.

Dear Yann E. MORIN,

On Wed, 9 Oct 2013 00:23:18 +0200, Yann E. MORIN wrote:

> > Huh? wayland.mk does build wayland-scanner with the native compiler
> > before starting the build itself. It doesn't work anymore with 1.2.x ?
> 
> He! I did not even check... Yes, it does.
> I basically did not expect wayland to build host tools.
> 
> I'll rework the series so wayland installs wayland-scanner to $(HOST),
> and use that instead of host-wayland.

Well, using a host-wayland package is certainly an alternate approach.
But at least at the time of wayland 1.1.x, building wayland-scanner
manually was very easy, so I thought it was the best solution to just
do it manually in wayland.mk. Should the build process of
wayland-scanner become too complicated, having a host-wayland package
would certainly be the appropriate solution.

Thomas

Thomas, All,

On 2013-10-09 00:25 +0200, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> On Wed, 9 Oct 2013 00:23:18 +0200, Yann E. MORIN wrote:
> 
> > > Huh? wayland.mk does build wayland-scanner with the native compiler
> > > before starting the build itself. It doesn't work anymore with 1.2.x ?
> > 
> > He! I did not even check... Yes, it does.
> > I basically did not expect wayland to build host tools.
> > 
> > I'll rework the series so wayland installs wayland-scanner to $(HOST),
> > and use that instead of host-wayland.
> 
> Well, using a host-wayland package is certainly an alternate approach.
> But at least at the time of wayland 1.1.x, building wayland-scanner
> manually was very easy, so I thought it was the best solution to just
> do it manually in wayland.mk. Should the build process of
> wayland-scanner become too complicated, having a host-wayland package
> would certainly be the appropriate solution.

As discussed on IRC, I'll go for the hand-crafted wayland-scanner
install.

Regards,
Yann E. MORIN.