Patchwork Add "mpc5200-simple-platform" to the list of supported boards

login
register
mail settings
Submitter Marcelo Dalmas
Date June 5, 2009, 11:20 p.m.
Message ID <461095.11075.qm@web111310.mail.gq1.yahoo.com>
Download mbox | patch
Permalink /patch/28167/
State Rejected, archived
Headers show

Comments

Marcelo Dalmas - June 5, 2009, 11:20 p.m.
Hello,

Adding  "mpc5200-simple-platform" to the list of supported boards allow to use the option "Generic support for simple MPC5200 based boards" without patching the kernel. Just set model to "mpc5200-simple-plataform" on your dts file.






      Veja quais são os assuntos do momento no Yahoo! +Buscados
http://br.maisbuscados.yahoo.com
Grant Likely - June 5, 2009, 11:52 p.m.
On Fri, Jun 5, 2009 at 5:20 PM, Marcelo Dalmas<m_dalmas@yahoo.com.br> wrote:
>
> Hello,
>
> Adding  "mpc5200-simple-platform" to the list of supported boards allow to use the option "Generic support for simple MPC5200 based boards" without patching the kernel. Just set model to "mpc5200-simple-plataform" on your dts file.
>
>
> diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> index c31e5b5..a2df795 100644
> --- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> @@ -50,6 +50,7 @@ static void __init mpc5200_simple_setup_arch(void)
>
>  /* list of the supported boards */
>  static char *board[] __initdata = {
> +       "mpc5200-simple-platform",
>        "intercontrol,digsy-mtc",
>        "phytec,pcm030",
>        "phytec,pcm032",

Sorry, nack.  For the time being, board support is listed explicitly
in mpc5200_simple.c and 'generic' compatible values are strongly
discouraged.  This is on purpose.

I have been thinking about coming up with a method for generic mpc5200
platform support code to bind against an otherwise unknown mpc5200
board, but there are subtleties here and considerable pain if it is
done wrong.

In the mean time, just patch your kernel with your board name(s) and
don't try to use a generic value like mpc5200-simple-platform.

BTW, please cc: the appropriate maintainers and developers when
posting patches to the Linux kernel.  The MAINTAINERS file and
'scripts/get_maintainer.pl -f <filename>' are useful tools here.

g.
Benjamin Herrenschmidt - June 6, 2009, 12:28 a.m.
On Fri, 2009-06-05 at 16:20 -0700, Marcelo Dalmas wrote:
> Hello,
> 
> Adding  "mpc5200-simple-platform" to the list of supported boards allow to use the option "Generic support for simple MPC5200 based boards" without patching the kernel. Just set model to "mpc5200-simple-plataform" on your dts file.

I'm generally against that. Some time you'll need to diverge and poof !
you lost the ability to identify your board... it's also a very linux
centric thing to put in the device-tree.

Cheers,
Ben.

> diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> index c31e5b5..a2df795 100644
> --- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> @@ -50,6 +50,7 @@ static void __init mpc5200_simple_setup_arch(void)
>  
>  /* list of the supported boards */
>  static char *board[] __initdata = {
> +	"mpc5200-simple-platform",
>  	"intercontrol,digsy-mtc",
>  	"phytec,pcm030",
>  	"phytec,pcm032",
> 
> 
> 
> 
>       Veja quais são os assuntos do momento no Yahoo! +Buscados
> http://br.maisbuscados.yahoo.com
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Patch

diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/platforms/52xx/mpc5200_simple.c
index c31e5b5..a2df795 100644
--- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
+++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
@@ -50,6 +50,7 @@  static void __init mpc5200_simple_setup_arch(void)
 
 /* list of the supported boards */
 static char *board[] __initdata = {
+	"mpc5200-simple-platform",
 	"intercontrol,digsy-mtc",
 	"phytec,pcm030",
 	"phytec,pcm032",