Patchwork [U-Boot,6/8] Tegra124: Add generic T124 build support

login
register
mail settings
Submitter Tom Warren
Date Oct. 7, 2013, 10:42 p.m.
Message ID <1381185778-25722-6-git-send-email-twarren@nvidia.com>
Download mbox | patch
Permalink /patch/281287/
State Changes Requested
Delegated to: Tom Warren
Headers show

Comments

Tom Warren - Oct. 7, 2013, 10:42 p.m.
Basic Tegra124 build support added - no specific
board is targeted.

Change-Id: Id16b44b5b394e03b121e702eaef2f49f55ab3da3
Signed-off-by: Tom Warren <twarren@nvidia.com>
---
 board/nvidia/common/board.c | 3 +++
 1 file changed, 3 insertions(+)
Stephen Warren - Oct. 8, 2013, 9:45 p.m.
On 10/07/2013 04:42 PM, Tom Warren wrote:
> Basic Tegra124 build support added - no specific
> board is targeted.

The content of this patch seems entirely unrelated to the commit
description.

BTW, if I apply each one of these patches in turn, rather than all of
them at once, can the entire code-base build correctly for all SoCs, or
will I get build errors? I suppose that the boards.cfg is added near the
end of the series, so perhaps there's no issue here.

Patch

diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
index 126e56e..3f78787 100644
--- a/board/nvidia/common/board.c
+++ b/board/nvidia/common/board.c
@@ -77,9 +77,12 @@  void __gpio_early_init_uart(void)
 void gpio_early_init_uart(void)
 __attribute__((weak, alias("__gpio_early_init_uart")));
 
+/* TODO(twarren@nvidia.com): Create this only in boards that have NAND */
 void __pin_mux_nand(void)
 {
+#if defined(CONFIG_TEGRA_NAND)
 	funcmux_select(PERIPH_ID_NDFLASH, FUNCMUX_DEFAULT);
+#endif
 }
 
 void pin_mux_nand(void) __attribute__((weak, alias("__pin_mux_nand")));