From patchwork Thu Jun  4 14:24:59 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: mtd/nand: max_retries off by one
Date: Thu, 04 Jun 2009 04:24:59 -0000
From: roel kluin <roel.kluin@gmail.com>
X-Patchwork-Id: 28100
Message-Id: <4A27D93B.9020906@gmail.com>
To: dwmw2@infradead.org
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mtd@lists.infradead.org

with `while (max_retries-- > 0)' max_retries reaches -1 after the loop.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

---


diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 40c2608..b9706ad 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -192,7 +192,7 @@ static void wait_op_done(struct mxc_nand_host *host, int max_retries,
 			}
 			udelay(1);
 		}
-		if (max_retries <= 0)
+		if (max_retries < 0)
 			DEBUG(MTD_DEBUG_LEVEL0, "%s(%d): INT not set\n",
 			      __func__, param);
 	}