Patchwork mtd/nand: max_retries off by one

login
register
mail settings
Submitter roel kluin
Date June 4, 2009, 2:24 p.m.
Message ID <4A27D93B.9020906@gmail.com>
Download mbox | patch
Permalink /patch/28100/
State Accepted, archived
Headers show

Comments

roel kluin - June 4, 2009, 2:24 p.m.
with `while (max_retries-- > 0)' max_retries reaches -1 after the loop.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---

Patch

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 40c2608..b9706ad 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -192,7 +192,7 @@  static void wait_op_done(struct mxc_nand_host *host, int max_retries,
 			}
 			udelay(1);
 		}
-		if (max_retries <= 0)
+		if (max_retries < 0)
 			DEBUG(MTD_DEBUG_LEVEL0, "%s(%d): INT not set\n",
 			      __func__, param);
 	}