From patchwork Sun Oct 6 03:52:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Ott X-Patchwork-Id: 280829 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B2FD02C00A7 for ; Sun, 6 Oct 2013 14:53:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753753Ab3JFDxR (ORCPT ); Sat, 5 Oct 2013 23:53:17 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40007 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753474Ab3JFDwn (ORCPT ); Sat, 5 Oct 2013 23:52:43 -0400 Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 3823F21B0F; Sat, 5 Oct 2013 23:52:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sat, 05 Oct 2013 23:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=signal11.us; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= mesmtp; bh=n9jIwcUOYVOfh8UvanfS/Ly8zwQ=; b=kdeFPhCfk3kaK3hLe9geS 80NcMwEKEMCNItBOhhVXO2mYYxrRqS7Zd+4AzaG5yETd7uTnOocXZiYSqMLu1SGQ CNlbhivqTvIMLdPHTaOg0IZZs3zwtQSiRlR4wnUH1H3FvLx1Uw+kc/Af+xZyQMuT AR3grDeUina/3d7m24uz3U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references; s=smtpout; bh=n9jIwcUOYVOfh8UvanfS/Ly8z wQ=; b=O2ROkD0F8qMea+MW69AgON9ZjpkR8VFXiX62fJVzrqT1zhbr4RmIT3cVZ r4Fe3I4qTsACcONdoVgEbH2mehvKR6AuJ6GMlsWAHorR0o3X/U+BD395EsCMHN8/ AjWdIq184FH6qs3YqrDqW2xwFaL8GPDJ3xErgUqkp7pperUIR8= X-Sasl-enc: iPQW6bzAlKSXe5k3EQi3/u6lz4+9F2K2FHAySwLjTMlz 1381031562 Received: from ato.hsd1.fl.comcast.net (unknown [76.29.154.88]) by mail.messagingengine.com (Postfix) with ESMTPA id 58442C00E7F; Sat, 5 Oct 2013 23:52:42 -0400 (EDT) From: Alan Ott To: Alexander Smirnov , Dmitry Eremin-Solenikov , "David S. Miller" , david@hauweele.net Cc: linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Ott Subject: [PATCH v1 3/3] mrf24j40: Use level-triggered interrupts Date: Sat, 5 Oct 2013 23:52:24 -0400 Message-Id: <1381031544-2960-4-git-send-email-alan@signal11.us> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1381031544-2960-1-git-send-email-alan@signal11.us> References: <1369188080-8904-1-git-send-email-alan@signal11.us> <1381031544-2960-1-git-send-email-alan@signal11.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The mrf24j40 generates level interrupts. There are rare cases where it appears that the interrupt line never gets de-asserted between interrupts, causing interrupts to be lost, and causing a hung device from the driver's perspective. Switching the driver to interpret these interrupts as level-triggered fixes this issue. Signed-off-by: Alan Ott --- drivers/net/ieee802154/mrf24j40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c index c1bc688..0632d34 100644 --- a/drivers/net/ieee802154/mrf24j40.c +++ b/drivers/net/ieee802154/mrf24j40.c @@ -678,7 +678,7 @@ static int mrf24j40_probe(struct spi_device *spi) ret = request_threaded_irq(spi->irq, NULL, mrf24j40_isr, - IRQF_TRIGGER_FALLING|IRQF_ONESHOT, + IRQF_TRIGGER_LOW|IRQF_ONESHOT, dev_name(&spi->dev), devrec);