Patchwork spi/tegra20-slink: Remove unused is_single_xfer check

login
register
mail settings
Submitter Mark Brown
Date Oct. 4, 2013, 3:42 p.m.
Message ID <1380901375-9901-1-git-send-email-broonie@kernel.org>
Download mbox | patch
Permalink /patch/280656/
State Not Applicable, archived
Headers show

Comments

Mark Brown - Oct. 4, 2013, 3:42 p.m.
From: Mark Brown <broonie@linaro.org>

Currently transfer_one_message() checks to see if the message consists of
a single spi_transfer and tells _start_transfer_one() but it just ignores
this. Don't bother.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/spi/spi-tegra20-slink.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
Laxman Dewangan - Oct. 4, 2013, 4:43 p.m.
On Friday 04 October 2013 09:12 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Currently transfer_one_message() checks to see if the message consists of
> a single spi_transfer and tells _start_transfer_one() but it just ignores
> this. Don't bother.
>

Yes, we dont need this as it was there to support HW bases CS control 
which is removed.

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index c74ee87..f8d4ef5 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -707,8 +707,7 @@  static void tegra_slink_deinit_dma_param(struct tegra_slink_data *tspi,
 }
 
 static int tegra_slink_start_transfer_one(struct spi_device *spi,
-		struct spi_transfer *t, bool is_first_of_msg,
-		bool is_single_xfer)
+		struct spi_transfer *t, bool is_first_of_msg)
 {
 	struct tegra_slink_data *tspi = spi_master_get_devdata(spi->master);
 	u32 speed;
@@ -828,7 +827,6 @@  static int tegra_slink_transfer_one_message(struct spi_master *master,
 			struct spi_message *msg)
 {
 	bool is_first_msg = true;
-	int single_xfer;
 	struct tegra_slink_data *tspi = spi_master_get_devdata(master);
 	struct spi_transfer *xfer;
 	struct spi_device *spi = msg->spi;
@@ -837,11 +835,9 @@  static int tegra_slink_transfer_one_message(struct spi_master *master,
 	msg->status = 0;
 	msg->actual_length = 0;
 
-	single_xfer = list_is_singular(&msg->transfers);
 	list_for_each_entry(xfer, &msg->transfers, transfer_list) {
 		INIT_COMPLETION(tspi->xfer_completion);
-		ret = tegra_slink_start_transfer_one(spi, xfer,
-					is_first_msg, single_xfer);
+		ret = tegra_slink_start_transfer_one(spi, xfer, is_first_msg);
 		if (ret < 0) {
 			dev_err(tspi->dev,
 				"spi can not start transfer, err %d\n", ret);