diff mbox

[2/2] ahci_platform: use dev_info() instead of printk()

Message ID 000701cec0c1$7138ebe0$53aac3a0$%han@samsung.com
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Jingoo Han Oct. 4, 2013, 5:20 a.m. UTC
Use the printk(KERN_INFO,...) call to to dev_info() instead,
to tie into the dynamic debugging infrastructure.

Also change "raw" printk() call to dev_info() to provide a better
error message to userspace so it can properly identify the device
and not just have to guess.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5440.

 drivers/ata/ahci_platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergei Shtylyov Oct. 4, 2013, 8:19 p.m. UTC | #1
On 04-10-2013 7:20, Jingoo Han wrote:

> Use the printk(KERN_INFO,...) call to to dev_info() instead,
> to tie into the dynamic debugging infrastructure.

> Also change "raw" printk() call to dev_info() to provide a better
> error message to userspace so it can properly identify the device
> and not just have to guess.

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

    Same comments to this patch.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 2daaee0..7d3b853 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -184,7 +184,7 @@  static int ahci_probe(struct platform_device *pdev)
 	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
 		host->flags |= ATA_HOST_PARALLEL_SCAN;
 	else
-		printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
+		dev_info(dev, "SSS flag set, parallel bus scan disabled\n");
 
 	if (pi.flags & ATA_FLAG_EM)
 		ahci_reset_em(host);