Patchwork [iptables-nftables,v2] xtables: arp: Parse properly target's options

login
register
mail settings
Submitter Tomasz Bursztyka
Date Oct. 3, 2013, 1 p.m.
Message ID <1380805247-12362-1-git-send-email-tomasz.bursztyka@linux.intel.com>
Download mbox | patch
Permalink /patch/280298/
State Accepted
Headers show

Comments

Tomasz Bursztyka - Oct. 3, 2013, 1 p.m.
Without this, target never gets its options parsed, so it's a bug.

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
---
 iptables/xtables-arp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch

diff --git a/iptables/xtables-arp.c b/iptables/xtables-arp.c
index 8072d90..411a699 100644
--- a/iptables/xtables-arp.c
+++ b/iptables/xtables-arp.c
@@ -1317,6 +1317,10 @@  int do_commandarp(struct nft_handle *h, int argc, char *argv[], char **table)
 			exit_tryhelp(2);
 
 		default:
+			if (target) {
+				xtables_option_tpcall(c, argv,
+						      invert, target, &fw);
+			}
 			break;
 		}
 		invert = FALSE;
@@ -1325,8 +1329,6 @@  int do_commandarp(struct nft_handle *h, int argc, char *argv[], char **table)
 	if (target)
 		xtables_option_tfcall(target);
 
-	/* Fix me: must put inverse options checking here --MN */
-
 	if (optind < argc)
 		xtables_error(PARAMETER_PROBLEM,
 			      "unknown arguments found on commandline");