Patchwork [v7,3/6] package/Makefile.in: don't force jobs when BR2_JLEVEL is empty

login
register
mail settings
Submitter Fabio Porcedda
Date Oct. 3, 2013, 12:10 p.m.
Message ID <1380802245-16978-4-git-send-email-fabio.porcedda@gmail.com>
Download mbox | patch
Permalink /patch/280294/
State Superseded
Headers show

Comments

Fabio Porcedda - Oct. 3, 2013, 12:10 p.m.
When the "BR2_JLEVEL" variable is empty use "make" without
the "-j" option, because to be able to use top-level parallel
make we must don't force the number of jobs in sub-make.

Example:
	make BR2_JLEVEL= -j8

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Arnout Vandecappelle - Oct. 3, 2013, 4:54 p.m.
On 10/03/13 14:10, Fabio Porcedda wrote:
> When the "BR2_JLEVEL" variable is empty use "make" without
> the "-j" option, because to be able to use top-level parallel
> make we must don't force the number of jobs in sub-make.
>
> Example:
> 	make BR2_JLEVEL= -j8
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

  Peter, can we get this committed?

  Regards,
  Arnout

> ---
>   package/Makefile.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 170ad78..d406901 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -18,7 +18,7 @@ PARALLEL_JOBS:=$(BR2_JLEVEL)
>   endif
>
>   MAKE1:=$(HOSTMAKE) -j1
> -MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS)
> +MAKE:=$(HOSTMAKE) $(if $(PARALLEL_JOBS),-j$(PARALLEL_JOBS))
>
>   # Compute GNU_TARGET_NAME
>   GNU_TARGET_NAME=$(ARCH)-buildroot-$(TARGET_OS)-$(LIBC)$(ABI)
>
Peter Korsgaard - Oct. 4, 2013, 1:08 p.m.
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 Arnout> On 10/03/13 14:10, Fabio Porcedda wrote:
 >> When the "BR2_JLEVEL" variable is empty use "make" without
 >> the "-j" option, because to be able to use top-level parallel
 >> make we must don't force the number of jobs in sub-make.
 >> 
 >> Example:
 >> make BR2_JLEVEL= -j8
 >> 
 >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
 >> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 >> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

 Arnout>  Peter, can we get this committed?

Yes, committed - Thanks.

Patch

diff --git a/package/Makefile.in b/package/Makefile.in
index 170ad78..d406901 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -18,7 +18,7 @@  PARALLEL_JOBS:=$(BR2_JLEVEL)
 endif
 
 MAKE1:=$(HOSTMAKE) -j1
-MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS)
+MAKE:=$(HOSTMAKE) $(if $(PARALLEL_JOBS),-j$(PARALLEL_JOBS))
 
 # Compute GNU_TARGET_NAME
 GNU_TARGET_NAME=$(ARCH)-buildroot-$(TARGET_OS)-$(LIBC)$(ABI)