Patchwork [iptables-nftables,3/3] xtables: arp: Do not add a useless prefix for afinfo_arp

login
register
mail settings
Submitter Tomasz Bursztyka
Date Oct. 3, 2013, 9:52 a.m.
Message ID <1380793977-9730-4-git-send-email-tomasz.bursztyka@linux.intel.com>
Download mbox | patch
Permalink /patch/280248/
State Not Applicable
Headers show

Comments

Tomasz Bursztyka - Oct. 3, 2013, 9:52 a.m.
Let's use libxt_ as it should, since CLASSIFY and now mangle targets
(the 2 only targets xtables-arp is going to use) are libxt_ prefixed.

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
---
 iptables/xtables-arp-standalone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Pablo Neira - Oct. 3, 2013, 10:37 a.m.
On Thu, Oct 03, 2013 at 12:52:57PM +0300, Tomasz Bursztyka wrote:
> Let's use libxt_ as it should, since CLASSIFY and now mangle targets
> (the 2 only targets xtables-arp is going to use) are libxt_ prefixed.

I think that .libprefix is ignored, so we don't really need this
change.

Are you noticing any problem when adding xtables-arp commands?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Bursztyka - Oct. 3, 2013, 10:42 a.m.
Hi Pablo,

> I think that .libprefix is ignored, so we don't really need this
> change.
>
> Are you noticing any problem when adding xtables-arp commands?

No indeed. It tries the prefix, and fallback to libxt_ as the default.
As you want then, this clarifies that at least we really don't have 
anything like libarp_ prefix

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/iptables/xtables-arp-standalone.c b/iptables/xtables-arp-standalone.c
index 8d4679f..a9c880f 100644
--- a/iptables/xtables-arp-standalone.c
+++ b/iptables/xtables-arp-standalone.c
@@ -47,7 +47,7 @@  extern const char *program_version, *program_name;
 static const struct xtables_afinfo afinfo_arp = {
         .kmod          = "arp_tables",
         .proc_exists   = "/proc/net/arp_tables_names",
-        .libprefix     = "libarp_",
+        .libprefix     = "libxt_",
         .family        = NFPROTO_ARP,
         .ipproto       = IPPROTO_IP,
         .so_rev_match  = -1,