nano: needs mmu
diff mbox

Message ID 1380766412.29754.0.camel@phoenix
State Accepted
Headers show

Commit Message

Axel Lin Oct. 3, 2013, 2:13 a.m. UTC
Fix below build error if !BR2_USE_MMU:

text.o: In function `execute_command':
text.c:(.text+0x7f8): undefined reference to `fork'
text.o: In function `do_int_speller':
text.c:(.text+0x3480): undefined reference to `fork'
text.c:(.text+0x34f4): undefined reference to `fork'
text.c:(.text+0x3568): undefined reference to `fork'
text.o: In function `do_alt_speller':
text.c:(.text+0x3914): undefined reference to `fork'
collect2: ld returned 1 exit status
make[3]: *** [nano] Error 1

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 package/nano/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Oct. 3, 2013, 10:12 a.m. UTC | #1
>>>>> "Axel" == Axel Lin <axel.lin@ingics.com> writes:

 Axel> Fix below build error if !BR2_USE_MMU:
 Axel> text.o: In function `execute_command':
 Axel> text.c:(.text+0x7f8): undefined reference to `fork'
 Axel> text.o: In function `do_int_speller':
 Axel> text.c:(.text+0x3480): undefined reference to `fork'
 Axel> text.c:(.text+0x34f4): undefined reference to `fork'
 Axel> text.c:(.text+0x3568): undefined reference to `fork'
 Axel> text.o: In function `do_alt_speller':
 Axel> text.c:(.text+0x3914): undefined reference to `fork'
 Axel> collect2: ld returned 1 exit status
 Axel> make[3]: *** [nano] Error 1

 Axel> Signed-off-by: Axel Lin <axel.lin@ingics.com>
 Axel> ---
 Axel>  package/nano/Config.in | 1 +
 Axel>  1 file changed, 1 insertion(+)

 Axel> diff --git a/package/nano/Config.in b/package/nano/Config.in
 Axel> index ef7f69d..036313f 100644
 Axel> --- a/package/nano/Config.in
 Axel> +++ b/package/nano/Config.in
 Axel> @@ -1,5 +1,6 @@
 Axel>  config BR2_PACKAGE_NANO
 Axel>  	bool "nano"
 Axel> +	depends on BR2_USE_MMU # fork()

The part using fork() is actually only built if the full blown nano
version is used, so I changed this to simply be:

       # full version uses fork()
       select BR2_PACKAGE_NANO_TINY if !BR2_USE_MMU

And committed, thanks.

Patch
diff mbox

diff --git a/package/nano/Config.in b/package/nano/Config.in
index ef7f69d..036313f 100644
--- a/package/nano/Config.in
+++ b/package/nano/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_NANO
 	bool "nano"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_NCURSES
 	help
 	  A nice ncurses-based editor. Started out as a clone of pico.