| Message ID | e8b51bd48c24d0fc4ee8adea5c138c9bf84191e9.1380703262.git.agordeev@redhat.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello, On Wed, Oct 02, 2013 at 12:48:21PM +0200, Alexander Gordeev wrote: > Make pci_msix_table_size() to return a error code if the device > does not support MSI-X. This update is needed to facilitate a > forthcoming re-design MSI/MSI-X interrupts enabling pattern. > > Device drivers will use this interface to obtain maximum number > of MSI-X interrupts the device supports and use that value in > the following call to pci_enable_msix() interface. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Hmmm... I probably missed something but why is this necessary? To discern between -EINVAL and -ENOSPC? If so, does that really matter? Thanks.
On Mon, Oct 07, 2013 at 02:10:43PM -0400, Tejun Heo wrote: > On Wed, Oct 02, 2013 at 12:48:21PM +0200, Alexander Gordeev wrote: > > Make pci_msix_table_size() to return a error code if the device > > does not support MSI-X. This update is needed to facilitate a > > forthcoming re-design MSI/MSI-X interrupts enabling pattern. > > > > Device drivers will use this interface to obtain maximum number > > of MSI-X interrupts the device supports and use that value in > > the following call to pci_enable_msix() interface. > > Hmmm... I probably missed something but why is this necessary? To > discern between -EINVAL and -ENOSPC? If so, does that really matter? pci_msix_table_size() is kind of helper and returns 0 if a device does not have MSI-X table. If we want drivers to use it we need return -EINVAL for MSI-X incapable/disabled devices. Nothing about -ENOSPC. > tejun
diff --git a/Documentation/PCI/MSI-HOWTO.txt b/Documentation/PCI/MSI-HOWTO.txt index a091780..35b2d64 100644 --- a/Documentation/PCI/MSI-HOWTO.txt +++ b/Documentation/PCI/MSI-HOWTO.txt @@ -255,6 +255,19 @@ MSI-X Table. This address is mapped by the PCI subsystem, and should not be accessed directly by the device driver. If the driver wishes to mask or unmask an interrupt, it should call disable_irq() / enable_irq(). +4.3.4 pci_msix_table_size + +int pci_msix_table_size(struct pci_dev *dev) + +This function could be used to retrieve number of entries in the device +MSI-X table. + +If this function returns a negative number, it indicates the device is +not capable of sending MSI-Xs. + +If this function returns a positive number, it indicates the maximum +number of MSI-X interrupt vectors that could be allocated. + 4.4 Handling devices implementing both MSI and MSI-X capabilities If a device implements both MSI and MSI-X capabilities, it can diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index b43f391..875c353 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -928,11 +928,12 @@ int pci_msix_table_size(struct pci_dev *dev) u16 control; if (!dev->msix_cap) - return 0; + return -EINVAL; pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control); return msix_table_size(control); } +EXPORT_SYMBOL(pci_msix_table_size); /** * pci_enable_msix - configure device's MSI-X capability structure @@ -962,6 +963,8 @@ int pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries, int nvec) return status; nr_entries = pci_msix_table_size(dev); + if (nr_entries < 0) + return nr_entries; if (nvec > nr_entries) return nr_entries; diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 31063ac..b4d86eb 100644 --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -80,6 +80,8 @@ static int pcie_port_enable_msix(struct pci_dev *dev, int *vectors, int mask) u32 reg32; nr_entries = pci_msix_table_size(dev); + if (nr_entries < 0) + return nr_entries; if (!nr_entries) return -EINVAL; if (nr_entries > PCIE_PORT_MAX_MSIX_ENTRIES)
Make pci_msix_table_size() to return a error code if the device does not support MSI-X. This update is needed to facilitate a forthcoming re-design MSI/MSI-X interrupts enabling pattern. Device drivers will use this interface to obtain maximum number of MSI-X interrupts the device supports and use that value in the following call to pci_enable_msix() interface. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- Documentation/PCI/MSI-HOWTO.txt | 13 +++++++++++++ drivers/pci/msi.c | 5 ++++- drivers/pci/pcie/portdrv_core.c | 2 ++ 3 files changed, 19 insertions(+), 1 deletions(-)