From patchwork Tue Oct 1 09:53:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 279390 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 279FF2C00A7 for ; Tue, 1 Oct 2013 19:53:24 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=default; b=GrII1ZKU/J8esLOovz0xv/YOdiA7Va npvylHpW4Ntrg2T7uaVdtM+U9St78cI1n2Hfg36Q34Ann6P0q2kSh1J41UNsdphx iuGT7tcCvTVKaNxxOLrYCmCnakUlfv3gMcMIPObwLJLzRysAvyRAAIlzGtUInGNP 6P1Yt1GRkmg6g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=default; bh=Gb61eBrp/55IYpLwMfWvQO0qEak=; b=sSDf 5mDPBYPaVmQe3GFkFqm2q4Ij1kqzKjsxlvBB6+eVlCsEr4RTM+A4BhSfRQyQDOZ3 k/rSP2fwOqCF+EGxDr4VzZUj7sOiM1ZPbmZOm3VtJblYrahZrR/Iy65zxkMVSYx+ u8Ny/qNIV0tFaAsyFQzHJ89KEK1PBowIGbQAPF0= Received: (qmail 11482 invoked by alias); 1 Oct 2013 09:53:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11473 invoked by uid 89); 1 Oct 2013 09:53:16 -0000 Received: from mail-pd0-f169.google.com (HELO mail-pd0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 01 Oct 2013 09:53:16 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=ALL_TRUSTED, AWL, BAYES_00, FREEMAIL_FROM autolearn=ham version=3.3.2 X-HELO: mail-pd0-f169.google.com Received: by mail-pd0-f169.google.com with SMTP id r10so7003153pdi.14 for ; Tue, 01 Oct 2013 02:53:14 -0700 (PDT) X-Received: by 10.68.197.73 with SMTP id is9mr28244994pbc.75.1380621194350; Tue, 01 Oct 2013 02:53:14 -0700 (PDT) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPSA id tz3sm5827212pbc.20.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Oct 2013 02:53:13 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 99DA3EA0039; Tue, 1 Oct 2013 19:23:08 +0930 (CST) Date: Tue, 1 Oct 2013 19:23:08 +0930 From: Alan Modra To: gcc-patches@gcc.gnu.org Subject: Re: expand_expr tweaks to fix PR57134 Message-ID: <20131001095308.GA24236@bubble.grove.modra.org> Mail-Followup-To: gcc-patches@gcc.gnu.org References: <20130612024834.GY6878@bubble.grove.modra.org> <20130614083832.GK21523@bubble.grove.modra.org> <20130913030720.GC22902@bubble.grove.modra.org> <20130924104335.GD5799@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130924104335.GD5799@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes I'm committing this cleanup patch to my PR 57134,57586 changes as obvious. That it is obvious can be seen from an assert in tree-ssa-operands.c get_asm_expr_operands(). /* This should have been split in gimplify_asm_expr. */ gcc_assert (!allows_reg || !is_inout); Bootstrapped, etc. powerpc64-linux. * stmt.c (expand_asm_operands): Revert part of 2013-09-24 special casing inout operands. Index: gcc/stmt.c =================================================================== --- gcc/stmt.c (revision 203053) +++ gcc/stmt.c (working copy) @@ -807,9 +807,7 @@ expand_asm_operands (tree string, tree outputs, tr || is_inout) { op = expand_expr (val, NULL_RTX, VOIDmode, - !allows_reg ? EXPAND_MEMORY - : !is_inout ? EXPAND_WRITE - : EXPAND_NORMAL); + !allows_reg ? EXPAND_MEMORY : EXPAND_WRITE); if (MEM_P (op)) op = validize_mem (op);