From patchwork Tue Oct 1 09:33:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 279384 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4E4542C0119 for ; Tue, 1 Oct 2013 19:34:05 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=aX8yUKjgzZTWYXzFl NCQWPhjjuMCK4BpNjkd956mIKTN7GtLLMYUVDmzfJoQUKIOq0cwLu8k59MAfdOaa tGIIBm+vv4+rOICZtqH7bPs0/Cv13fLwjuSCUyV2TxYMxAalahradnk3N4rrGERR 5kY/6dFiSDo1a/0d83yGhbhQKU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=Qo0/+U/mW9fZSOUCV+8MnKx fCt4=; b=VFhy3yBthheFwFLly/0Ulj17b8Vzcmhb4SbzsH2H1Z+BCoqs0rkwd9p eeHcVfP0wZXf14qEp3c5txYgfIrTdYmVUTySn7lVRCrsPkFY6PlMvjb63kQEf+u9 ljedTeOv981cg+4Rgt4BCyzCxc45nCyeKR3S9sSlnzmntr83EV8w= Received: (qmail 26745 invoked by alias); 1 Oct 2013 09:33:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26733 invoked by uid 89); 1 Oct 2013 09:33:58 -0000 Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 09:33:58 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 01 Oct 2013 10:33:54 +0100 Received: from [10.1.208.24] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 1 Oct 2013 10:33:52 +0100 Message-ID: <524A9700.8090607@arm.com> Date: Tue, 01 Oct 2013 10:33:52 +0100 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Richard Biener CC: Xinliang David Li , GCC Patches Subject: Re: cost model patch References: <524952A5.3090900@arm.com> In-Reply-To: X-MC-Unique: 113100110335408601 X-IsSubscribed: yes On 01/10/13 09:28, Richard Biener wrote: > On Mon, Sep 30, 2013 at 5:26 PM, Xinliang David Li wrote: >> Yes, that will do. Can you do it for me? I can't do testing easily >> on arm myself. > It also fails on x86_64 with -m32. I always test on x86_64 with > multilibs enabled: > > make -k -j12 check RUNTESTFLAGS="--target_board=unix/\{,-m32\}" Appears on aarch64-none-elf as well... This patch makes the tests pass for me. I notice there's PR58556 that talks about these failures, so shall I link this patch to this PR? Ok to apply? Kyrill P.S. Since we've changed the default cost model for the vectoriser, perhaps we should consider reorganising the vectoriser tests taking into consideration what tests apply to which cost model? [gcc/testsuite/] 2013-10-01 Kyrylo Tkachov PR tree-optimization/58556 * gcc.dg/tree-ssa/gen-vect-26.c: Use dynamic vector cost model. * gcc.dg/tree-ssa/gen-vect-28.c: Likewise. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c index f14bf83..dadeb07 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -fvect-cost-model=dynamic" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -fvect-cost-model=dynamic -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include diff --git a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-28.c b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-28.c index d90520e..f314b28 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-28.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-28.c @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -fvect-cost-model=dynamic" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -fvect-cost-model=dynamic -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include