From patchwork Tue Oct 1 09:11:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 279379 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id D731C2C03A1 for ; Tue, 1 Oct 2013 19:11:45 +1000 (EST) Received: by ozlabs.org (Postfix) id 5D5472C00CB; Tue, 1 Oct 2013 19:11:21 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from pokefinder.org (sauhun.de [89.238.76.85]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 00F172C013B for ; Tue, 1 Oct 2013 19:11:20 +1000 (EST) Received: from p4fe2569f.dip0.t-ipconnect.de ([79.226.86.159]:34332 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1VQvzA-0002PV-NW; Tue, 01 Oct 2013 11:11:16 +0200 Date: Tue, 1 Oct 2013 11:11:15 +0200 From: Wolfram Sang To: Sebastian Andrzej Siewior Subject: Re: [PATCH] Revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()" Message-ID: <20131001091115.GB2993@katana> References: <1380612366-13504-1-git-send-email-wsa@the-dreams.de> <524A7FCB.3020406@linutronix.de> MIME-Version: 1.0 In-Reply-To: <524A7FCB.3020406@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: linuxppc-dev@ozlabs.org, Anatolij Gustschin , linux-rt-users@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16rc2 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On Tue, Oct 01, 2013 at 09:54:51AM +0200, Sebastian Andrzej Siewior wrote: > On 10/01/2013 09:26 AM, Wolfram Sang wrote: > > This reverts commit 6391f697d4892a6f233501beea553e13f7745a23. The > > compiler warning it wants to fix does not appear with my gcc 4.6.2. IMO > > we don't need superfluous (and here even misleading) code to make old > > compilers happy. Fixing the printout was bogus, too. We want to know > > WHICH critical irq failed, not which level it had. > > According to minimal Doc*/Changes minimal gcc is 3.2. Mine was 4.3.5. Well, if you insist, I'd prefer the following patch. From: Wolfram Sang Subject: [PATCH] ppc: mpc52xx: silence false positive from old GCC So people can compile with -Werror (RT patchset). Signed-off-by: Wolfram Sang --- arch/powerpc/platforms/52xx/mpc52xx_pic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) > Why miss leading code? Default here does the same as unhandled and crit > where it does nothing. People not realizing 'default' is a no-op might wonder why unknown levels are mapped to critical. > Any why do you want to see l2irq since it was > not in the case statement? l2 holds the number, l1 the level. We know which level it was, since the printout is only for that level. We probably want to know which requested IRQ was causing this, so we can fix the assorted driver. Otherwise we only know that some critical IRQ was requested somewhere. > You were but your email bounced. I wasn't aware of this new email > address you are using now. Ah, I see, pity. Thanks, Wolfram diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c index b89ef65..ad3c9b0 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c @@ -340,7 +340,7 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq, { int l1irq; int l2irq; - struct irq_chip *irqchip; + struct irq_chip *irqchip = NULL; /* pet old compilers */ void *hndlr; int type; u32 reg;